X-Git-Url: https://git.novaco.in/?a=blobdiff_plain;f=Novacoin%2FCTransaction.cs;h=a061c70769885cb029fbfb4dc621ff56b232c64c;hb=624ac1021490395614a0cbee619c79860c22061a;hp=ab1a5efb27d41d5144c93e17e9be348a5a657d22;hpb=f1d2e217ae6e24a84edfa98ca3471a8a836ecaa7;p=NovacoinLibrary.git
diff --git a/Novacoin/CTransaction.cs b/Novacoin/CTransaction.cs
index ab1a5ef..a061c70 100644
--- a/Novacoin/CTransaction.cs
+++ b/Novacoin/CTransaction.cs
@@ -19,6 +19,9 @@
using System;
using System.Text;
using System.Collections.Generic;
+using System.IO;
+using System.Diagnostics.Contracts;
+using System.Numerics;
namespace Novacoin
{
@@ -39,13 +42,32 @@ namespace Novacoin
{
}
}
-
+
///
- /// Represents the transaction. Any transaction must provide one input and one output at least.
+ /// Represents the transaction.
///
public class CTransaction
{
///
+ /// One cent = 10000 satoshis.
+ ///
+ public const ulong nCent = 10000;
+
+ ///
+ /// One coin = 1000000 satoshis.
+ ///
+ public const ulong nCoin = 1000000;
+ ///
+ /// Sanity checking threshold.
+ ///
+ public const ulong nMaxMoney = 2000000000 * nCoin;
+
+ ///
+ /// Maximum transaction size is 250Kb
+ ///
+ public const uint nMaxTxSize = 250000;
+
+ ///
/// Version of transaction schema.
///
public uint nVersion;
@@ -111,6 +133,10 @@ namespace Novacoin
nLockTime = tx.nLockTime;
}
+ ///
+ /// Attempts to execute all transaction scripts and validate the results.
+ ///
+ /// Checking result.
public bool VerifyScripts()
{
if (IsCoinBase)
@@ -118,35 +144,150 @@ namespace Novacoin
return true;
}
- CTransaction txPrev = null;
+ TxOutItem txOutCursor = null;
for (int i = 0; i < vin.Length; i++)
{
var outpoint = vin[i].prevout;
- if (!CBlockStore.Instance.GetTransaction(outpoint.hash, ref txPrev))
+ if (!CBlockStore.Instance.GetTxOutCursor(outpoint, ref txOutCursor))
+ return false;
+
+ if (!ScriptCode.VerifyScript(vin[i].scriptSig, txOutCursor.scriptPubKey, this, i, (int)scriptflag.SCRIPT_VERIFY_P2SH, 0))
+ return false;
+ }
+
+ return true;
+ }
+
+ ///
+ /// Calculate amount of signature operations without trying to properly evaluate P2SH scripts.
+ ///
+ public uint LegacySigOpCount
+ {
+ get
+ {
+ uint nSigOps = 0;
+ foreach (var txin in vin)
+ {
+ nSigOps += txin.scriptSig.GetSigOpCount(false);
+ }
+ foreach (var txout in vout)
+ {
+ nSigOps += txout.scriptPubKey.GetSigOpCount(false);
+ }
+
+ return nSigOps;
+ }
+ }
+
+ ///
+ /// Basic sanity checkings
+ ///
+ /// Checking result
+ public bool CheckTransaction()
+ {
+ if (Size > nMaxTxSize || vin.Length == 0 || vout.Length == 0)
+ {
+ return false;
+ }
+
+ // Check for empty or overflow output values
+ ulong nValueOut = 0;
+ for (int i = 0; i < vout.Length; i++)
+ {
+ CTxOut txout = vout[i];
+ if (txout.IsEmpty && !IsCoinBase && !IsCoinStake)
+ {
+ // Empty outputs aren't allowed for user transactions.
+ return false;
+ }
+
+ nValueOut += txout.nValue;
+ if (!MoneyRange(nValueOut))
+ {
+ return false;
+ }
+ }
+
+ // Check for duplicate inputs
+ var InOutPoints = new List();
+ foreach (var txin in vin)
+ {
+ if (InOutPoints.IndexOf(txin.prevout) != -1)
+ {
+ // Duplicate input.
return false;
+ }
+ InOutPoints.Add(txin.prevout);
+ }
- if (!ScriptCode.VerifyScript(vin[i].scriptSig, txPrev.vout[outpoint.n].scriptPubKey, this, i, (int)scriptflag.SCRIPT_VERIFY_P2SH, 0))
+ if (IsCoinBase)
+ {
+ if (vin[0].scriptSig.Size < 2 || vin[0].scriptSig.Size > 100)
+ {
+ // Script size is invalid
return false;
+ }
+ }
+ else
+ {
+ foreach (var txin in vin)
+ {
+ if (txin.prevout.IsNull)
+ {
+ // Null input in non-coinbase transaction.
+ return false;
+ }
+ }
}
return true;
}
+ public bool IsFinal(uint nBlockHeight = 0, uint nBlockTime = 0)
+ {
+ // Time based nLockTime
+ if (nLockTime == 0)
+ {
+ return true;
+ }
+ if (nBlockHeight == 0)
+ {
+ nBlockHeight = uint.MaxValue; // TODO: stupid stub here, should be best height instead.
+ }
+ if (nBlockTime == 0)
+ {
+ nBlockTime = NetInfo.GetAdjustedTime();
+ }
+ if (nLockTime < (nLockTime < NetInfo.nLockTimeThreshold ? nBlockHeight : nBlockTime))
+ {
+ return true;
+ }
+ foreach (var txin in vin)
+ {
+ if (!txin.IsFinal)
+ {
+ return false;
+ }
+ }
+ return true;
+ }
+
///
/// Parse byte sequence and initialize new instance of CTransaction
///
/// Byte sequence
- public CTransaction(byte[] txBytes)
+ public CTransaction(byte[] txBytes)
{
try
{
- var wBytes = new ByteQueue(txBytes);
+ var stream = new MemoryStream(txBytes);
+ var reader = new BinaryReader(stream);
- nVersion = BitConverter.ToUInt32(wBytes.Get(4), 0);
- nTime = BitConverter.ToUInt32(wBytes.Get(4), 0);
+ nVersion = reader.ReadUInt32();
+ nTime = reader.ReadUInt32();
- int nInputs = (int)wBytes.GetVarInt();
+ int nInputs = (int)VarInt.ReadVarInt(ref reader);
vin = new CTxIn[nInputs];
for (int nCurrentInput = 0; nCurrentInput < nInputs; nCurrentInput++)
@@ -154,28 +295,28 @@ namespace Novacoin
// Fill inputs array
vin[nCurrentInput] = new CTxIn();
- vin[nCurrentInput].prevout = new COutPoint(wBytes.Get(36));
+ vin[nCurrentInput].prevout = new COutPoint(reader.ReadBytes(36));
- int nScriptSigLen = (int)wBytes.GetVarInt();
- vin[nCurrentInput].scriptSig = new CScript(wBytes.Get(nScriptSigLen));
+ int nScriptSigLen = (int)VarInt.ReadVarInt(ref reader);
+ vin[nCurrentInput].scriptSig = new CScript(reader.ReadBytes(nScriptSigLen));
- vin[nCurrentInput].nSequence = BitConverter.ToUInt32(wBytes.Get(4), 0);
+ vin[nCurrentInput].nSequence = reader.ReadUInt32();
}
- int nOutputs = (int)wBytes.GetVarInt();
+ int nOutputs = (int)VarInt.ReadVarInt(ref reader);
vout = new CTxOut[nOutputs];
for (int nCurrentOutput = 0; nCurrentOutput < nOutputs; nCurrentOutput++)
{
// Fill outputs array
vout[nCurrentOutput] = new CTxOut();
- vout[nCurrentOutput].nValue = BitConverter.ToUInt64(wBytes.Get(8), 0);
+ vout[nCurrentOutput].nValue = reader.ReadUInt64();
- int nScriptPKLen = (int)wBytes.GetVarInt();
- vout[nCurrentOutput].scriptPubKey = new CScript(wBytes.Get(nScriptPKLen));
+ int nScriptPKLen = (int)VarInt.ReadVarInt(ref reader);
+ vout[nCurrentOutput].scriptPubKey = new CScript(reader.ReadBytes(nScriptPKLen));
}
- nLockTime = BitConverter.ToUInt32(wBytes.Get(4), 0);
+ nLockTime = reader.ReadUInt32();
}
catch (Exception e)
{
@@ -214,12 +355,12 @@ namespace Novacoin
///
/// Bytes sequence
/// Transactions array
- public static CTransaction[] ReadTransactionsList(ref ByteQueue wTxBytes)
+ internal static CTransaction[] ReadTransactionsList(ref BinaryReader reader)
{
try
{
// Read amount of transactions
- int nTransactions = (int)wTxBytes.GetVarInt();
+ int nTransactions = (int)VarInt.ReadVarInt(ref reader);
var tx = new CTransaction[nTransactions];
for (int nTx = 0; nTx < nTransactions; nTx++)
@@ -227,16 +368,16 @@ namespace Novacoin
// Fill the transactions array
tx[nTx] = new CTransaction();
- tx[nTx].nVersion = BitConverter.ToUInt32(wTxBytes.Get(4), 0);
- tx[nTx].nTime = BitConverter.ToUInt32(wTxBytes.Get(4), 0);
+ tx[nTx].nVersion = reader.ReadUInt32();
+ tx[nTx].nTime = reader.ReadUInt32();
// Inputs array
- tx[nTx].vin = CTxIn.ReadTxInList(ref wTxBytes);
+ tx[nTx].vin = CTxIn.ReadTxInList(ref reader);
// outputs array
- tx[nTx].vout = CTxOut.ReadTxOutList(ref wTxBytes);
+ tx[nTx].vout = CTxOut.ReadTxOutList(ref reader);
- tx[nTx].nLockTime = BitConverter.ToUInt32(wTxBytes.Get(4), 0);
+ tx[nTx].nLockTime = reader.ReadUInt32();
}
return tx;
@@ -264,9 +405,26 @@ namespace Novacoin
///
/// Transaction hash
///
- public Hash256 Hash
+ public uint256 Hash
{
- get { return Hash256.Compute256(this); }
+ get { return CryptoUtils.ComputeHash256(this); }
+ }
+
+ ///
+ /// Amount of novacoins spent by this transaction.
+ ///
+ public ulong nValueOut
+ {
+ get
+ {
+ ulong nValueOut = 0;
+ foreach (var txout in vout)
+ {
+ nValueOut += txout.nValue;
+ Contract.Assert(MoneyRange(txout.nValue) && MoneyRange(nValueOut));
+ }
+ return nValueOut;
+ }
}
///
@@ -274,27 +432,30 @@ namespace Novacoin
///
public static implicit operator byte[] (CTransaction tx)
{
- var resultBytes = new List();
+ var stream = new MemoryStream();
+ var writer = new BinaryWriter(stream);
- resultBytes.AddRange(BitConverter.GetBytes(tx.nVersion));
- resultBytes.AddRange(BitConverter.GetBytes(tx.nTime));
- resultBytes.AddRange(VarInt.EncodeVarInt(tx.vin.LongLength));
+ writer.Write(tx.nVersion);
+ writer.Write(tx.nTime);
+ writer.Write(VarInt.EncodeVarInt(tx.vin.LongLength));
foreach (var input in tx.vin)
{
- resultBytes.AddRange((byte[])input);
+ writer.Write(input);
}
- resultBytes.AddRange(VarInt.EncodeVarInt(tx.vout.LongLength));
+ writer.Write(VarInt.EncodeVarInt(tx.vout.LongLength));
foreach (var output in tx.vout)
{
- resultBytes.AddRange((byte[])output);
+ writer.Write(output);
}
- resultBytes.AddRange(BitConverter.GetBytes(tx.nLockTime));
+ writer.Write(tx.nLockTime);
+ var resultBytes = stream.ToArray();
+ writer.Close();
- return resultBytes.ToArray();
+ return resultBytes;
}
public override string ToString()
@@ -305,17 +466,29 @@ namespace Novacoin
foreach (var txin in vin)
{
- sb.AppendFormat(" {0},\n", txin.ToString());
+ sb.AppendFormat(" {0},\n", txin);
}
foreach (var txout in vout)
{
- sb.AppendFormat(" {0},\n", txout.ToString());
+ sb.AppendFormat(" {0},\n", txout);
}
sb.AppendFormat("\nnLockTime={0}\n)", nLockTime);
return sb.ToString();
}
- }
+
+ public static bool MoneyRange(ulong nValue) { return (nValue <= nMaxMoney); }
+
+ internal uint GetP2SHSigOpCount(Dictionary inputs)
+ {
+ throw new NotImplementedException();
+ }
+
+ internal ulong GetValueIn(Dictionary inputs)
+ {
+ throw new NotImplementedException();
+ }
+ }
}