Johannes Henninger [Mon, 1 Aug 2011 14:34:59 +0000]
Identify as "Bitcoin + version number" when mapping UPnP port
Makes Bitcoin identify itself as "Bitcoin + version number" instead of
the nondescript "libminiupnpc" when forwarding a port via UPnP.
Gavin Andresen [Sun, 31 Jul 2011 23:56:56 +0000]
Merge pull request #437 from codler/patch-2
Comment "deprecated"
Han Lin Yap [Sat, 30 Jul 2011 16:58:22 +0000]
Comment "deprecated"
Pieter Wuille [Wed, 27 Jul 2011 20:10:47 +0000]
Merge pull request #436 from TheBlueMatt/master
Fix EncryptKeys crash introduced by a9ba471, identified by TD.
Matt Corallo [Wed, 27 Jul 2011 16:02:39 +0000]
Fix EncryptKeys crash introduced by
a9ba4710, identified by TD.
Jeff Garzik [Tue, 26 Jul 2011 19:15:55 +0000]
CAddrDB::LoadAddresses: properly initialize CAddress
Fixes issue #424
Pieter Wuille [Tue, 26 Jul 2011 17:43:00 +0000]
Merge pull request #435 from sipa/fixextract
Bugfix: don't overuse limited ExtractAddress
Pieter Wuille [Tue, 26 Jul 2011 17:15:45 +0000]
Bugfix: don't overuse limited ExtractAddress
ExtractAddress was called with the keystore as argument in RPC and
UI, limiting results to own keys. This caused empty "address"
fields.
Pieter Wuille [Tue, 26 Jul 2011 15:46:48 +0000]
Merge pull request #434 from laanwj/addkey_retval
make SetHash160 return a value (as specified in the function signature)
Wladimir J. van der Laan [Tue, 26 Jul 2011 14:54:32 +0000]
make SetHash160 return a value (as specified in the function signature)
Jeff Garzik [Sun, 24 Jul 2011 22:38:38 +0000]
Merge pull request #403 from sipa/cbitcoinaddress
keys indexed by address + introduced CBitcoinaddress
Pieter Wuille [Sun, 24 Jul 2011 15:08:33 +0000]
Merge pull request #428 from sipa/mintxfeefix
Fix for small change outputs
Pieter Wuille [Sun, 24 Jul 2011 14:37:09 +0000]
Fix for small change outputs
With the separation of CENT and MIN_TX_FEE, it is now reasonable
to create change outputs between 0.01 and 0.0005, as these are
spendable according to the policy, even though they require a fee
to be paid.
Also, when enough fee was already present, everything can go into
a change output, without further increasing the fee.
Jeff Garzik [Fri, 22 Jul 2011 02:05:38 +0000]
Merge pull request #423 from TheBlueMatt/mapalreadyaskedforfix
Actually use mapAlreadyAskedFor.
Matt Corallo [Thu, 21 Jul 2011 20:06:20 +0000]
Actually use mapAlreadyAskedFor.
Previously, mapAlreadyAskedFor was read from, but never added to.
The original intent was to use mapAlreadyAskedFor to keep track
of the time an item was requested and "Each retry is 2 minutes
after the last".
This implements that intent.
Pieter Wuille [Mon, 18 Jul 2011 13:38:54 +0000]
Merge pull request #1 from AbrahamJewowich/cbitcoinaddress
Cbitcoinaddress
Abraham Jewowich [Mon, 18 Jul 2011 13:26:54 +0000]
Fix bug with accessing vchData[0] when vchData is empty.
Fix typo in CBase58Data::CompareTo
Gavin Andresen [Mon, 18 Jul 2011 00:52:40 +0000]
Merge pull request #419 from mibe/translation-de
Updated German translation
Gavin Andresen [Mon, 18 Jul 2011 00:51:08 +0000]
Merge pull request #395 from mibe/issue-395
Error in Russian Translation
Pieter Wuille [Mon, 11 Jul 2011 09:09:00 +0000]
split off CBase58Data from CBitcoinAddress
Split off features unrelated to addresses from CBitcoinAddress to
CBase58Data, so they can be reused.
Pieter Wuille [Tue, 5 Jul 2011 18:53:43 +0000]
Use CBitcoinAddress instead of string/uint160
Instead of conversion functions between pubkey/uint160/address in
base58.h, have a fully fledged class CBitcoinAddress (CAddress was
already taken) to represent addresses.
Pieter Wuille [Tue, 5 Jul 2011 14:42:32 +0000]
get rid of mapPubKeys
Make CKeyStore's interface work on uint160's instead of pubkeys, so
no separate global mapPubKeys is necessary anymore.
Michael Bemmerl [Sun, 17 Jul 2011 02:22:50 +0000]
Changed Russian translation according to comment in issue 395
Michael Bemmerl [Sun, 17 Jul 2011 00:56:10 +0000]
Added German wallet encryption messages translation.
Michael Bemmerl [Sun, 17 Jul 2011 00:19:49 +0000]
Basically some grammatical fixes of the German translation.
Jeff Garzik [Sat, 16 Jul 2011 04:11:34 +0000]
Merge pull request #418 from EricJ2190/master
Update makefile.vc for wallet encryptions.
Eric Hosmer [Sat, 16 Jul 2011 03:38:46 +0000]
Added crypter to makefile.vc.
Jeff Garzik [Fri, 15 Jul 2011 03:43:22 +0000]
Merge pull request #414 from spiechu/polish-translation
added polish wallet encryption messages
Dawid Spiechowicz [Thu, 14 Jul 2011 17:13:26 +0000]
added polish wallet encryption messages
Jeff Garzik [Thu, 14 Jul 2011 16:37:50 +0000]
Merge pull request #413 from TheBlueMatt/loadwalletret
Fix bad return values in LoadWallet.
Matt Corallo [Thu, 14 Jul 2011 16:15:50 +0000]
Fix bad return values in LoadWallet.
Pieter Wuille [Thu, 14 Jul 2011 12:29:09 +0000]
Merge pull request #412 from sgimenez/db-transactions
Single DB transactions
Stéphane Gimenez [Thu, 14 Jul 2011 00:57:39 +0000]
Single DB transaction for addresses from DNS seeds
Gavin Andresen [Thu, 14 Jul 2011 01:36:56 +0000]
Merge pull request #411 from TheBlueMatt/master
Fix Build in GetReservedKey() in wallet.cpp
Matt Corallo [Thu, 14 Jul 2011 01:31:45 +0000]
Fix Build in GetReservedKey() in wallet.cpp
Gavin Andresen [Thu, 14 Jul 2011 01:29:55 +0000]
Merge pull request #410 from TheBlueMatt/master
Generate Warning when using default key.
Patrick Varilly [Thu, 14 Jul 2011 00:45:34 +0000]
Single DB transaction for all addresses in a message
Cuts disk activity at startup immensely
Matt Corallo [Thu, 14 Jul 2011 01:28:31 +0000]
Generate Warning when using default key.
Jeff Garzik [Thu, 14 Jul 2011 01:22:19 +0000]
Merge pull request #409 from TheBlueMatt/master
Fix crashes when a wallet is locked and GetReservedKey() is called
Matt Corallo [Thu, 14 Jul 2011 01:11:40 +0000]
Fix crashes when a wallet is locked and GetReservedKey() is called
Jeff Garzik [Wed, 13 Jul 2011 15:55:49 +0000]
Merge pull request #406 from muggenhor/warning-fixes
Warning fixes
Jeff Garzik [Wed, 13 Jul 2011 15:53:57 +0000]
Merge pull request #405 from sipa/syncdefault
Bugfix: add autogenerated addresses to address book
Giel van Schijndel [Wed, 13 Jul 2011 11:43:50 +0000]
fix warning: control reaches end of non-void function [-Wreturn-type]
Signed-off-by: Giel van Schijndel <me@mortis.eu>
Giel van Schijndel [Wed, 13 Jul 2011 11:43:24 +0000]
fix warning: variable ‘nMinDepth’ set but not used [-Wunused-but-set-variable]
Signed-off-by: Giel van Schijndel <me@mortis.eu>
Pieter Wuille [Wed, 13 Jul 2011 11:14:16 +0000]
Merge pull request #404 from TheBlueMatt/newenc
Fix makefile.linux-mingw
Matt Corallo [Wed, 13 Jul 2011 11:12:49 +0000]
Fix makefile.linux-mingw
Pieter Wuille [Wed, 13 Jul 2011 11:05:08 +0000]
Bugfix: add autogenerated addresses to address book
Jeff Garzik [Wed, 13 Jul 2011 05:21:49 +0000]
doc/README: word wrap into something readable
Jeff Garzik [Wed, 13 Jul 2011 05:19:26 +0000]
Bump version to 0.3.25
Yes, we might release as v0.4, but let's just do a simple increment
for now.
Jeff Garzik [Wed, 13 Jul 2011 05:07:49 +0000]
Update CWallet::LoadWallet for proper return type.
Jeff Garzik [Wed, 13 Jul 2011 03:22:38 +0000]
Merge pull request #399 from muggenhor/warning-fixes
Warning fixes
Giel van Schijndel [Fri, 24 Jun 2011 20:14:15 +0000]
fix warning: unused function 'SigIllHandlerSSE2' [-Wunused-function]
Only declare & define SigIllHandlerSSE2 when its used.
Signed-off-by: Giel van Schijndel <me@mortis.eu>
Giel van Schijndel [Fri, 24 Jun 2011 20:00:59 +0000]
fix warning: unused variable 'X' [-Wunused-variable]
Remove several unused variables.
Signed-off-by: Giel van Schijndel <me@mortis.eu>
Giel van Schijndel [Fri, 24 Jun 2011 18:47:26 +0000]
fix warning: X enumeration values not handled in switch [-Wswitch-enum]
Add default cases to opcode switches to assert that they should never
occur.
Signed-off-by: Giel van Schijndel <me@mortis.eu>
Giel van Schijndel [Fri, 24 Jun 2011 18:09:24 +0000]
fix warning: comparison of unsigned expression < 0 is always false [-Wtautological-compare]
Don't check for a negative parameter count, because not only will it
never happen, it doesn't make any sense either.
Invalid sockets (as returned by socket(2)) are always exactly -1 (not
just negative as negative file descriptors are technically not
prohibited by POSIX) on POSIX systems. Since we store them in SOCKET
(unsigned int), however, that really is ~0U (or MAX_UINT) which happens
to be what INVALID_SOCKET is already defined to, so an additional check
for being negative is not only unnecessary (unsigned integers aren't
*ever* negative) its redundant as well (the INVALID_SOCKET comparison is
enough).
Signed-off-by: Giel van Schijndel <me@mortis.eu>
Giel van Schijndel [Fri, 24 Jun 2011 18:03:16 +0000]
fix warnings: using the result of an assignment as a condition without parentheses [-Wparentheses]
Don't unnecessarily assign to variables within the *boolean* expression
of a conditional.
Signed-off-by: Giel van Schijndel <me@mortis.eu>
Giel van Schijndel [Fri, 24 Jun 2011 17:56:23 +0000]
fix warnings: expression result unused [-Wunused-value]
In the assert()s take advantage of the fact that string constants
("string") are effectively of type 'const char []', which when used in
an expression yield a non-NULL pointer.
An assertion that should always fail can thus be formulated as:
assert(!"fail);
An assertion where a text message should be added to the expression can
be written as such:
assert("message" && expression);
Signed-off-by: Giel van Schijndel <me@mortis.eu>
Giel van Schijndel [Tue, 12 Jul 2011 12:24:14 +0000]
fix warning on 64bit systems: cast to pointer from integer of different size [-Wint-to-pointer-cast]
Signed-off-by: Giel van Schijndel <me@mortis.eu>
Matt Corallo [Wed, 13 Jul 2011 02:38:13 +0000]
Update makefile.linux-mingw to work with crypter and UPnP fix.
Jeff Garzik [Wed, 13 Jul 2011 02:34:30 +0000]
Merge pull request #381 from TheBlueMatt/nminversion
Add minversion to wallet.
Jeff Garzik [Wed, 13 Jul 2011 02:18:52 +0000]
Merge pull request #402 from jayschwa/hirez-icon
High resolution Windows icon
Jeff Garzik [Wed, 13 Jul 2011 02:18:21 +0000]
Merge pull request #396 from jayschwa/nsis-branding
Add bitcoin.org logos/branding to NSIS installer.
Jeff Garzik [Wed, 13 Jul 2011 02:10:12 +0000]
Merge pull request #352 from TheBlueMatt/newenc
Wallet Private Key Encryption (on CWallet)
Jay Weisskopf [Wed, 13 Jul 2011 01:13:44 +0000]
Increase resolution of Windows icon.
The .ico file has changed in the following ways:
* Added 64x64 layer (max size for "Classic Mode").
* Added 256x256 layer (max size for Vista and 7).
* Removed copies with no alpha channel:
* Display depths lower than 32-bits are rare nowadays.
* 8-bit alpha channels in icons has been supported since XP.
* If the display depth is lowered, they look no better than the
downsampled versions that Windows automatically generates.
Tested various sizes on both XP and Win 7. It looks fine
(unchanged) on XP and downright sexy on Win 7.
Matt Corallo [Sun, 10 Jul 2011 14:07:22 +0000]
Make an invalid addrIncoming so that old clients crash.
This prevents old clients from opening, and thus corrupting
or otherwise causing harm to encrypted wallets.
Matt Corallo [Fri, 8 Jul 2011 13:08:27 +0000]
Use DB Transactions when encrypting wallet.
This speeds up the encryption process significantly.
Pieter Wuille [Sun, 3 Jul 2011 13:33:01 +0000]
Do not use obsolete CPrivKey for passing keys around
Matt Corallo [Sat, 2 Jul 2011 21:08:35 +0000]
Add Wallet Encryption section to README
Matt Corallo [Thu, 30 Jun 2011 00:09:47 +0000]
Add the walletlock RPC method to lock the wallet manually.
Matt Corallo [Tue, 28 Jun 2011 23:08:48 +0000]
Dynamically remove/insert the Options for encryption in the menus.
Matt Corallo [Tue, 28 Jun 2011 22:47:41 +0000]
Push unlocked_until in getinfo.
Matt Corallo [Tue, 28 Jun 2011 13:31:09 +0000]
Set the number of SHA512 rounds based on the speed of the computer.
Matt Corallo [Fri, 8 Jul 2011 13:47:35 +0000]
Add wallet privkey encryption.
This commit adds support for ckeys, or enCrypted private keys, to the wallet.
All keys are stored in memory in their encrypted form and thus the passphrase
is required from the user to spend coins, or to create new addresses.
Keys are encrypted with AES-256-CBC using OpenSSL's EVP library. The key is
calculated via EVP_BytesToKey using SHA512 with (by default) 25000 rounds and
a random salt.
By default, the user's wallet remains unencrypted until they call the RPC
command encryptwallet <passphrase> or, from the GUI menu, Options->
Encrypt Wallet.
When the user is attempting to call RPC functions which require the password
to unlock the wallet, an error will be returned unless they call
walletpassphrase <passphrase> <time to keep key in memory> first.
A keypoolrefill command has been added which tops up the users keypool
(requiring the passphrase via walletpassphrase first).
keypoolsize has been added to the output of getinfo to show the user the
number of keys left before they need to specify their passphrase (and call
keypoolrefill).
Note that walletpassphrase will automatically fill keypool in a separate
thread which it spawns when the passphrase is set. This could cause some
delays in other threads waiting for locks on the wallet passphrase, including
one which could cause the passphrase to be stored longer than expected,
however it will not allow the passphrase to be used longer than expected as
ThreadCleanWalletPassphrase will attempt to get a lock on the key as soon
as the specified lock time has arrived.
When the keypool runs out (and wallet is locked) GetOrReuseKeyFromPool
returns vchDefaultKey, meaning miners may start to generate many blocks to
vchDefaultKey instead of a new key each time.
A walletpassphrasechange <oldpassphrase> <newpassphrase> has been added to
allow the user to change their password via RPC.
Whenever keying material (unencrypted private keys, the user's passphrase,
the wallet's AES key) is stored unencrypted in memory, any reasonable attempt
is made to mlock/VirtualLock that memory before storing the keying material.
This is not true in several (commented) cases where mlock/VirtualLocking the
memory is not possible.
Although encryption of private keys in memory can be very useful on desktop
systems (as some small amount of protection against stupid viruses), on an
RPC server, the password is entered fairly insecurely. Thus, the only main
advantage encryption has for RPC servers is for RPC servers that do not spend
coins, except in rare cases, eg. a webserver of a merchant which only receives
payment except for cases of manual intervention.
Thanks to jgarzik for the original patch and sipa, gmaxwell and many others
for all their input.
Conflicts:
src/wallet.cpp
Jay Weisskopf [Tue, 12 Jul 2011 06:18:57 +0000]
Remove NSIS branding from bottom divider.
Jay Weisskopf [Mon, 11 Jul 2011 07:11:15 +0000]
Set default compression for NSIS installer to LZMA.
Use of LZMA (versus the current zlib) shaves a few MB off the installer.
Jay Weisskopf [Mon, 11 Jul 2011 07:09:07 +0000]
Add logos/branding currently found on bitcoin.org into NSIS installer.
Doug Huff [Thu, 30 Jun 2011 00:04:44 +0000]
Make mlock() and munlock() portable to systems that require the address to be on a page boundary.
Jeff Garzik [Sat, 9 Jul 2011 17:09:13 +0000]
Merge pull request #392 from laanwj/antimagic
Remove another magic number: change threshold for nLockTime to constant
Wladimir J. van der Laan [Sat, 9 Jul 2011 08:06:49 +0000]
remove magic number: change threshold for nLockTime to constant
Jeff Garzik [Fri, 8 Jul 2011 17:38:24 +0000]
Compile 'sv' translation
Jeff Garzik [Fri, 8 Jul 2011 17:36:49 +0000]
Merge pull request #376 from codler/translate
Minor translation changes for latest build (Swedish)
Dylan Noblesmith [Fri, 24 Jun 2011 03:03:17 +0000]
mlock() all private keys in memory
Inline comment and idea come from the encprivkeys branch
by Matt Corallo <matt@bluematt.me>.
Pieter Wuille [Sat, 25 Jun 2011 12:57:32 +0000]
Prepare codebase for Encrypted Keys.
Jeff Garzik [Tue, 5 Jul 2011 18:52:13 +0000]
Merge pull request #383 from sipa/syncdefault
Fix synchronization of default key
Jeff Garzik [Tue, 5 Jul 2011 17:10:26 +0000]
Merge pull request #384 from TheBlueMatt/upnp
Fix UPnP building, entirely my fault.
Matt Corallo [Tue, 5 Jul 2011 01:06:19 +0000]
Add minversion to wallet.
Matt Corallo [Tue, 5 Jul 2011 16:21:35 +0000]
Enable UPnP by default on bitcoin, but not on bitcoind (on gitian)
Also fix a minor type in gitian.yml
Matt Corallo [Tue, 5 Jul 2011 16:19:34 +0000]
Revert "Make UPnP default on Bitcoin but not on Bitcoind."
This reverts commit
ee1f884229736da6f5443157ccba97f4e8f50f82.
Stupid, stupid me...there is exactly 0 way to convince make to
execute a conditional based on a target-specific variable.
Pieter Wuille [Tue, 5 Jul 2011 15:42:44 +0000]
Fix synchronization of default key
Gavin Andresen [Tue, 5 Jul 2011 02:26:10 +0000]
Merge pull request #379 from gavinandresen/nocommas
Do not use comma as thousands separator
Jeff Garzik [Mon, 4 Jul 2011 23:34:18 +0000]
Merge pull request #380 from TheBlueMatt/buildupdates
Added a couple minor things to match newer build process.
Matt Corallo [Sun, 3 Jul 2011 12:41:09 +0000]
Added a couple minor things to match newer build process.
This adds the relevent patches which are applied to wx,
and updates for cross compiling.
Gavin Andresen [Mon, 4 Jul 2011 13:41:58 +0000]
Do not use comma as thousands separator
Using the comma as thousands separator causes problems for parts of the world
where comma == decimal point. Germans sending 0,001 bitcoins are unpleasantly
surprised when that results in 1 BTC getting sent.
Gavin Andresen [Sun, 3 Jul 2011 15:20:39 +0000]
Block-chain lock-in at 134444
Han Lin Yap [Sun, 3 Jul 2011 13:24:47 +0000]
Minor translation changes for latest build
Jeff Garzik [Sat, 2 Jul 2011 20:57:45 +0000]
Bump OSX version to 0.3.24 (missed in previous commit)
Jeff Garzik [Sat, 2 Jul 2011 20:55:11 +0000]
Bump version to 0.3.24.
Jeff Garzik [Sat, 2 Jul 2011 20:46:07 +0000]
Merge branch 'tmp2' into tmp3
Jeff Garzik [Sat, 2 Jul 2011 19:04:09 +0000]
Merge pull request #374 from TheBlueMatt/neterror
Give more detailed error messages for connection failure.
Matt Corallo [Sat, 2 Jul 2011 01:59:37 +0000]
Give more detailed error messages for connection failure.