Gavin Andresen [Sat, 13 Aug 2011 00:52:38 +0000]
Remove unused ScanMessageStart function
Jeff Garzik [Tue, 16 Aug 2011 14:10:39 +0000]
src/makefile.unix: remove -DFOURWAYSSE2
Spotted by Venkatesh Srinivas <me@endeavour.zapto.org>
Gavin Andresen [Fri, 12 Aug 2011 19:39:12 +0000]
Don't std::advance past beginning of transactions array. Fixes #465
Gavin Andresen [Thu, 11 Aug 2011 17:34:29 +0000]
Merge pull request #458 from TheBlueMatt/copyright
Unify copyright notices.
Gavin Andresen [Thu, 11 Aug 2011 03:01:37 +0000]
Merge pull request #459 from jgarzik/char-msgstart
Use 'unsigned char' rather than 'char' for pchMessageStart.
Gavin Andresen [Thu, 11 Aug 2011 03:01:14 +0000]
Merge pull request #460 from jgarzik/make-tuple
Qualify make_tuple with boost:: namespace.
Venkatesh Srinivas [Sun, 7 Aug 2011 16:19:14 +0000]
Use 'unsigned char' rather than 'char' for pchMessageStart.
Regarding https://bitcointalk.org/index.php?topic=28022.0
main.cpp has: "char pchMessageStart[4] = { 0xf9, 0xbe, 0xb4, 0xd9 };"
Per discussion on the thread linked, leaving the signedness of
pchMessageStart is unsafe for values > 0x80. This patch specifies
'unsigned char' in main.cpp and net.h.
Signed-off-by: Jeff Garzik <jgarzik@pobox.com>
Venkatesh Srinivas [Sun, 7 Aug 2011 16:20:00 +0000]
Qualify make_tuple with boost:: namespace.
db.cpp has a number of uses of make_tuple and has 'using namespace
std' and 'using namespace boost'. Without qualifying make_tuple,
std::make_tuple is preferred, which is incorrect. This patch qualifies
make_tuple.
Signed-off-by: Jeff Garzik <jgarzik@exmulti.com>
Venkatesh Srinivas [Sun, 7 Aug 2011 16:18:05 +0000]
Test for SO_NOSIGPIPE rather than assuming all BSDs support it.
Signed-off-by: Jeff Garzik <jgarzik@exmulti.com>
Gavin Andresen [Tue, 9 Aug 2011 16:38:17 +0000]
Do-nothing MapPort() ifndef USE_UPNP. fixes #450
Matt Corallo [Tue, 9 Aug 2011 11:27:58 +0000]
Unify copyright notices.
To a variation on:
// Copyright (c) 2009-2010 Satoshi Nakamoto
// Copyright (c) 2011 The Bitcoin developers
Matt Corallo [Tue, 2 Aug 2011 15:34:23 +0000]
Cleanup test suite output to be more useful.
Matt Corallo [Sun, 31 Jul 2011 18:07:53 +0000]
Add file for transaction tests.
Vegard Nossum [Sun, 31 Jul 2011 18:01:31 +0000]
Add a file for script tests
Vegard Nossum [Wed, 29 Jun 2011 10:33:21 +0000]
Add prototype for EvalScript() to script.h
This is needed for the script unit tests.
Vegard Nossum [Sun, 31 Jul 2011 18:00:38 +0000]
Fix testing setup
There were some problems with the existing testing setup:
- Makefile rules for test-file compilation used CFLAGS instead of
CXXFLAGS in makefile.unix
Matt Corallo [Sun, 31 Jul 2011 01:14:25 +0000]
Add missing include to serialize.h
Vegard Nossum [Wed, 29 Jun 2011 10:18:18 +0000]
Add missing includes to net.h
Vegard Nossum [Wed, 29 Jun 2011 10:17:49 +0000]
Add missing include to script.h
Vegard Nossum [Sun, 26 Jun 2011 14:11:56 +0000]
Add missing includes to key.h
Gavin Andresen [Mon, 8 Aug 2011 18:16:40 +0000]
Merge pull request #443 from TheBlueMatt/dupin
Check for duplicate txins in CheckTransaction.
Jeff Garzik [Thu, 4 Aug 2011 19:22:05 +0000]
Merge branch 'tmp2'
Jeff Garzik [Thu, 4 Aug 2011 18:47:15 +0000]
Merge pull request #448 from sipa/cbitcoinaddress
avoid strAddress + validity checks
Jeff Garzik [Thu, 4 Aug 2011 18:40:44 +0000]
Merge pull request #446 from WakiMiko/upnp-desc
Identify as "Bitcoin + version number" when mapping UPnP port
Jeff Garzik [Thu, 4 Aug 2011 18:40:06 +0000]
Merge pull request #451 from TheBlueMatt/tornolisten
Don't listen if on TOR (resolves #441).
Matt Corallo [Wed, 3 Aug 2011 19:02:37 +0000]
Don't listen if on TOR (resolves #441).
Matt Corallo [Wed, 3 Aug 2011 19:02:07 +0000]
Make it clear that setting proxy requires restart to fully apply.
Pieter Wuille [Wed, 3 Aug 2011 11:00:27 +0000]
avoid strAddress + validity checks
Avoid references to addresses using strings, and use CBitcoinAddress
as much as possible. Also added some validity checks on addresses
entered using RPC.
Pieter Wuille [Mon, 1 Aug 2011 20:41:43 +0000]
Merge pull request #444 from Jeroenz0r/patch-2
Translation from "Open Bitcoin" to "Verstuur Bitcoins"
Johannes Henninger [Mon, 1 Aug 2011 14:34:59 +0000]
Identify as "Bitcoin + version number" when mapping UPnP port
Makes Bitcoin identify itself as "Bitcoin + version number" instead of
the nondescript "libminiupnpc" when forwarding a port via UPnP.
Gavin Andresen [Sun, 31 Jul 2011 23:56:56 +0000]
Merge pull request #437 from codler/patch-2
Comment "deprecated"
Jeroenz0r [Sun, 31 Jul 2011 23:03:19 +0000]
Translation from "Open Bitcoin" to "Verstuur Bitcoins"
Matt Corallo [Sat, 30 Jul 2011 21:01:45 +0000]
Check for duplicate txins in CheckTransaction.
Han Lin Yap [Sat, 30 Jul 2011 16:58:22 +0000]
Comment "deprecated"
Pieter Wuille [Wed, 27 Jul 2011 20:10:47 +0000]
Merge pull request #436 from TheBlueMatt/master
Fix EncryptKeys crash introduced by a9ba471, identified by TD.
Matt Corallo [Wed, 27 Jul 2011 16:02:39 +0000]
Fix EncryptKeys crash introduced by
a9ba4710, identified by TD.
Jeff Garzik [Tue, 26 Jul 2011 19:15:55 +0000]
CAddrDB::LoadAddresses: properly initialize CAddress
Fixes issue #424
Pieter Wuille [Tue, 26 Jul 2011 17:43:00 +0000]
Merge pull request #435 from sipa/fixextract
Bugfix: don't overuse limited ExtractAddress
Pieter Wuille [Tue, 26 Jul 2011 17:15:45 +0000]
Bugfix: don't overuse limited ExtractAddress
ExtractAddress was called with the keystore as argument in RPC and
UI, limiting results to own keys. This caused empty "address"
fields.
Pieter Wuille [Tue, 26 Jul 2011 15:46:48 +0000]
Merge pull request #434 from laanwj/addkey_retval
make SetHash160 return a value (as specified in the function signature)
Wladimir J. van der Laan [Tue, 26 Jul 2011 14:54:32 +0000]
make SetHash160 return a value (as specified in the function signature)
JoelKatz [Mon, 25 Jul 2011 22:06:45 +0000]
Fix UNIX-specific thread handle leak.
Jeff Garzik [Sun, 24 Jul 2011 22:38:38 +0000]
Merge pull request #403 from sipa/cbitcoinaddress
keys indexed by address + introduced CBitcoinaddress
Pieter Wuille [Sun, 24 Jul 2011 15:08:33 +0000]
Merge pull request #428 from sipa/mintxfeefix
Fix for small change outputs
Pieter Wuille [Sun, 24 Jul 2011 14:37:09 +0000]
Fix for small change outputs
With the separation of CENT and MIN_TX_FEE, it is now reasonable
to create change outputs between 0.01 and 0.0005, as these are
spendable according to the policy, even though they require a fee
to be paid.
Also, when enough fee was already present, everything can go into
a change output, without further increasing the fee.
Jeff Garzik [Fri, 22 Jul 2011 02:05:38 +0000]
Merge pull request #423 from TheBlueMatt/mapalreadyaskedforfix
Actually use mapAlreadyAskedFor.
Matt Corallo [Thu, 21 Jul 2011 20:06:20 +0000]
Actually use mapAlreadyAskedFor.
Previously, mapAlreadyAskedFor was read from, but never added to.
The original intent was to use mapAlreadyAskedFor to keep track
of the time an item was requested and "Each retry is 2 minutes
after the last".
This implements that intent.
Pieter Wuille [Mon, 18 Jul 2011 13:38:54 +0000]
Merge pull request #1 from AbrahamJewowich/cbitcoinaddress
Cbitcoinaddress
Abraham Jewowich [Mon, 18 Jul 2011 13:26:54 +0000]
Fix bug with accessing vchData[0] when vchData is empty.
Fix typo in CBase58Data::CompareTo
Gavin Andresen [Mon, 18 Jul 2011 00:52:40 +0000]
Merge pull request #419 from mibe/translation-de
Updated German translation
Gavin Andresen [Mon, 18 Jul 2011 00:51:08 +0000]
Merge pull request #395 from mibe/issue-395
Error in Russian Translation
Pieter Wuille [Mon, 11 Jul 2011 09:09:00 +0000]
split off CBase58Data from CBitcoinAddress
Split off features unrelated to addresses from CBitcoinAddress to
CBase58Data, so they can be reused.
Pieter Wuille [Tue, 5 Jul 2011 18:53:43 +0000]
Use CBitcoinAddress instead of string/uint160
Instead of conversion functions between pubkey/uint160/address in
base58.h, have a fully fledged class CBitcoinAddress (CAddress was
already taken) to represent addresses.
Pieter Wuille [Tue, 5 Jul 2011 14:42:32 +0000]
get rid of mapPubKeys
Make CKeyStore's interface work on uint160's instead of pubkeys, so
no separate global mapPubKeys is necessary anymore.
Michael Bemmerl [Sun, 17 Jul 2011 02:22:50 +0000]
Changed Russian translation according to comment in issue 395
Michael Bemmerl [Sun, 17 Jul 2011 00:56:10 +0000]
Added German wallet encryption messages translation.
Michael Bemmerl [Sun, 17 Jul 2011 00:19:49 +0000]
Basically some grammatical fixes of the German translation.
Jeff Garzik [Sat, 16 Jul 2011 04:11:34 +0000]
Merge pull request #418 from EricJ2190/master
Update makefile.vc for wallet encryptions.
Eric Hosmer [Sat, 16 Jul 2011 03:38:46 +0000]
Added crypter to makefile.vc.
Jeff Garzik [Fri, 15 Jul 2011 03:43:22 +0000]
Merge pull request #414 from spiechu/polish-translation
added polish wallet encryption messages
Dawid Spiechowicz [Thu, 14 Jul 2011 17:13:26 +0000]
added polish wallet encryption messages
Jeff Garzik [Thu, 14 Jul 2011 16:37:50 +0000]
Merge pull request #413 from TheBlueMatt/loadwalletret
Fix bad return values in LoadWallet.
Matt Corallo [Thu, 14 Jul 2011 16:15:50 +0000]
Fix bad return values in LoadWallet.
Pieter Wuille [Thu, 14 Jul 2011 12:29:09 +0000]
Merge pull request #412 from sgimenez/db-transactions
Single DB transactions
Stéphane Gimenez [Thu, 14 Jul 2011 00:57:39 +0000]
Single DB transaction for addresses from DNS seeds
Gavin Andresen [Thu, 14 Jul 2011 01:36:56 +0000]
Merge pull request #411 from TheBlueMatt/master
Fix Build in GetReservedKey() in wallet.cpp
Matt Corallo [Thu, 14 Jul 2011 01:31:45 +0000]
Fix Build in GetReservedKey() in wallet.cpp
Gavin Andresen [Thu, 14 Jul 2011 01:29:55 +0000]
Merge pull request #410 from TheBlueMatt/master
Generate Warning when using default key.
Patrick Varilly [Thu, 14 Jul 2011 00:45:34 +0000]
Single DB transaction for all addresses in a message
Cuts disk activity at startup immensely
Matt Corallo [Thu, 14 Jul 2011 01:28:31 +0000]
Generate Warning when using default key.
Jeff Garzik [Thu, 14 Jul 2011 01:22:19 +0000]
Merge pull request #409 from TheBlueMatt/master
Fix crashes when a wallet is locked and GetReservedKey() is called
Matt Corallo [Thu, 14 Jul 2011 01:11:40 +0000]
Fix crashes when a wallet is locked and GetReservedKey() is called
Jeff Garzik [Wed, 13 Jul 2011 15:55:49 +0000]
Merge pull request #406 from muggenhor/warning-fixes
Warning fixes
Jeff Garzik [Wed, 13 Jul 2011 15:53:57 +0000]
Merge pull request #405 from sipa/syncdefault
Bugfix: add autogenerated addresses to address book
Giel van Schijndel [Wed, 13 Jul 2011 11:43:50 +0000]
fix warning: control reaches end of non-void function [-Wreturn-type]
Signed-off-by: Giel van Schijndel <me@mortis.eu>
Giel van Schijndel [Wed, 13 Jul 2011 11:43:24 +0000]
fix warning: variable ‘nMinDepth’ set but not used [-Wunused-but-set-variable]
Signed-off-by: Giel van Schijndel <me@mortis.eu>
Pieter Wuille [Wed, 13 Jul 2011 11:14:16 +0000]
Merge pull request #404 from TheBlueMatt/newenc
Fix makefile.linux-mingw
Matt Corallo [Wed, 13 Jul 2011 11:12:49 +0000]
Fix makefile.linux-mingw
Pieter Wuille [Wed, 13 Jul 2011 11:05:08 +0000]
Bugfix: add autogenerated addresses to address book
Jeff Garzik [Wed, 13 Jul 2011 05:21:49 +0000]
doc/README: word wrap into something readable
Jeff Garzik [Wed, 13 Jul 2011 05:19:26 +0000]
Bump version to 0.3.25
Yes, we might release as v0.4, but let's just do a simple increment
for now.
Jeff Garzik [Wed, 13 Jul 2011 05:07:49 +0000]
Update CWallet::LoadWallet for proper return type.
Jeff Garzik [Wed, 13 Jul 2011 03:22:38 +0000]
Merge pull request #399 from muggenhor/warning-fixes
Warning fixes
Giel van Schijndel [Fri, 24 Jun 2011 20:14:15 +0000]
fix warning: unused function 'SigIllHandlerSSE2' [-Wunused-function]
Only declare & define SigIllHandlerSSE2 when its used.
Signed-off-by: Giel van Schijndel <me@mortis.eu>
Giel van Schijndel [Fri, 24 Jun 2011 20:00:59 +0000]
fix warning: unused variable 'X' [-Wunused-variable]
Remove several unused variables.
Signed-off-by: Giel van Schijndel <me@mortis.eu>
Giel van Schijndel [Fri, 24 Jun 2011 18:47:26 +0000]
fix warning: X enumeration values not handled in switch [-Wswitch-enum]
Add default cases to opcode switches to assert that they should never
occur.
Signed-off-by: Giel van Schijndel <me@mortis.eu>
Giel van Schijndel [Fri, 24 Jun 2011 18:09:24 +0000]
fix warning: comparison of unsigned expression < 0 is always false [-Wtautological-compare]
Don't check for a negative parameter count, because not only will it
never happen, it doesn't make any sense either.
Invalid sockets (as returned by socket(2)) are always exactly -1 (not
just negative as negative file descriptors are technically not
prohibited by POSIX) on POSIX systems. Since we store them in SOCKET
(unsigned int), however, that really is ~0U (or MAX_UINT) which happens
to be what INVALID_SOCKET is already defined to, so an additional check
for being negative is not only unnecessary (unsigned integers aren't
*ever* negative) its redundant as well (the INVALID_SOCKET comparison is
enough).
Signed-off-by: Giel van Schijndel <me@mortis.eu>
Giel van Schijndel [Fri, 24 Jun 2011 18:03:16 +0000]
fix warnings: using the result of an assignment as a condition without parentheses [-Wparentheses]
Don't unnecessarily assign to variables within the *boolean* expression
of a conditional.
Signed-off-by: Giel van Schijndel <me@mortis.eu>
Giel van Schijndel [Fri, 24 Jun 2011 17:56:23 +0000]
fix warnings: expression result unused [-Wunused-value]
In the assert()s take advantage of the fact that string constants
("string") are effectively of type 'const char []', which when used in
an expression yield a non-NULL pointer.
An assertion that should always fail can thus be formulated as:
assert(!"fail);
An assertion where a text message should be added to the expression can
be written as such:
assert("message" && expression);
Signed-off-by: Giel van Schijndel <me@mortis.eu>
Giel van Schijndel [Tue, 12 Jul 2011 12:24:14 +0000]
fix warning on 64bit systems: cast to pointer from integer of different size [-Wint-to-pointer-cast]
Signed-off-by: Giel van Schijndel <me@mortis.eu>
Matt Corallo [Wed, 13 Jul 2011 02:38:13 +0000]
Update makefile.linux-mingw to work with crypter and UPnP fix.
Jeff Garzik [Wed, 13 Jul 2011 02:34:30 +0000]
Merge pull request #381 from TheBlueMatt/nminversion
Add minversion to wallet.
Jeff Garzik [Wed, 13 Jul 2011 02:18:52 +0000]
Merge pull request #402 from jayschwa/hirez-icon
High resolution Windows icon
Jeff Garzik [Wed, 13 Jul 2011 02:18:21 +0000]
Merge pull request #396 from jayschwa/nsis-branding
Add bitcoin.org logos/branding to NSIS installer.
Jeff Garzik [Wed, 13 Jul 2011 02:10:12 +0000]
Merge pull request #352 from TheBlueMatt/newenc
Wallet Private Key Encryption (on CWallet)
Jay Weisskopf [Wed, 13 Jul 2011 01:13:44 +0000]
Increase resolution of Windows icon.
The .ico file has changed in the following ways:
* Added 64x64 layer (max size for "Classic Mode").
* Added 256x256 layer (max size for Vista and 7).
* Removed copies with no alpha channel:
* Display depths lower than 32-bits are rare nowadays.
* 8-bit alpha channels in icons has been supported since XP.
* If the display depth is lowered, they look no better than the
downsampled versions that Windows automatically generates.
Tested various sizes on both XP and Win 7. It looks fine
(unchanged) on XP and downright sexy on Win 7.
Matt Corallo [Sun, 10 Jul 2011 14:07:22 +0000]
Make an invalid addrIncoming so that old clients crash.
This prevents old clients from opening, and thus corrupting
or otherwise causing harm to encrypted wallets.
Matt Corallo [Fri, 8 Jul 2011 13:08:27 +0000]
Use DB Transactions when encrypting wallet.
This speeds up the encryption process significantly.
Pieter Wuille [Sun, 3 Jul 2011 13:33:01 +0000]
Do not use obsolete CPrivKey for passing keys around
Matt Corallo [Sat, 2 Jul 2011 21:08:35 +0000]
Add Wallet Encryption section to README