Don't check proof-of-stake signature twice.
authorCryptoManiac <balthazar@yandex.ru>
Thu, 10 Sep 2015 19:08:11 +0000 (22:08 +0300)
committerCryptoManiac <balthazar@yandex.ru>
Thu, 10 Sep 2015 19:08:11 +0000 (22:08 +0300)
Novacoin/CBlock.cs
Novacoin/CBlockStore.cs

index 450612a..fba1387 100644 (file)
@@ -164,7 +164,7 @@ namespace Novacoin
                     return false;
                 }
 
-                // Coinbase output should be empty if proof-of-stake block
+                // Coinbase output must be empty if proof-of-stake block
                 if (vtx[0].vout.Length != 1 || !vtx[0].vout[0].IsEmpty)
                 {
                     return false;
@@ -179,7 +179,7 @@ namespace Novacoin
                 // Check proof-of-stake block signature
                 if (fCheckSig && !SignatureOK)
                 {
-                    return false;
+                    return false; // Proof-of-Stake signature checking failure.
                 }
 
                 if (!vtx[1].CheckTransaction())
index 1d0d1a9..6b03f08 100644 (file)
@@ -1281,12 +1281,6 @@ namespace Novacoin
 
             if (block.IsProofOfStake)
             {
-                if (!block.SignatureOK)
-                {
-                    // Proof-of-Stake signature validation failure.
-                    return false;
-                }
-
                 // TODO: proof-of-stake validation
 
                 uint256 hashProofOfStake = 0, targetProofOfStake = 0;