From: CryptoManiac <balthazar@yandex.ru>
Date: Tue, 8 Sep 2015 23:07:48 +0000 (+0300)
Subject: Add incompatibility notice.
X-Git-Url: https://git.novaco.in/?p=NovacoinLibrary.git;a=commitdiff_plain;h=12807e425dfe9da0b3d6ac18b3422e2b8135f24a

Add incompatibility notice.

System.Numerics based implementation of GetProofOfWorkReward function produces incorrect reward values.

OpenSSL:

```
bnUpperBound=100000000, bnLowerBound=50005000, bnMidValue=50005000
bnUpperBound=75002500, bnLowerBound=50005000, bnMidValue=75002500
bnUpperBound=62503750, bnLowerBound=50005000, bnMidValue=62503750
bnUpperBound=56254375, bnLowerBound=50005000, bnMidValue=56254375
bnUpperBound=56254375, bnLowerBound=53129687, bnMidValue=53129687
bnUpperBound=54692031, bnLowerBound=53129687, bnMidValue=54692031
bnUpperBound=54692031, bnLowerBound=53910859, bnMidValue=53910859
bnUpperBound=54301445, bnLowerBound=53910859, bnMidValue=54301445
bnUpperBound=54301445, bnLowerBound=54106152, bnMidValue=54106152
bnUpperBound=54301445, bnLowerBound=54203798, bnMidValue=54203798
bnUpperBound=54301445, bnLowerBound=54252621, bnMidValue=54252621
bnUpperBound=54301445, bnLowerBound=54277033, bnMidValue=54277033
bnUpperBound=54301445, bnLowerBound=54289239, bnMidValue=54289239
bnUpperBound=54295342, bnLowerBound=54289239, bnMidValue=54295342
```

System.Numerics:

```
bnUpperBound=100000000 bnLowerBound=50005000 bnMidValue=50005000
bnUpperBound=75002500 bnLowerBound=50005000 bnMidValue=75002500
bnUpperBound=62503750 bnLowerBound=50005000 bnMidValue=62503750
bnUpperBound=56254375 bnLowerBound=50005000 bnMidValue=56254375
bnUpperBound=56254375 bnLowerBound=53129687 bnMidValue=53129687
bnUpperBound=54692031 bnLowerBound=53129687 bnMidValue=54692031
bnUpperBound=54692031 bnLowerBound=53910859 bnMidValue=53910859
bnUpperBound=54301445 bnLowerBound=53910859 bnMidValue=54301445
bnUpperBound=54301445 bnLowerBound=54106152 bnMidValue=54106152
bnUpperBound=54301445 bnLowerBound=54203798 bnMidValue=54203798
bnUpperBound=54301445 bnLowerBound=54252621 bnMidValue=54252621
bnUpperBound=54301445 bnLowerBound=54277033 bnMidValue=54277033
bnUpperBound=54301445 bnLowerBound=54289239 bnMidValue=54289239
bnUpperBound=54301445 bnLowerBound=54295342 bnMidValue=54295342
```
---

diff --git a/Novacoin/CBlock.cs b/Novacoin/CBlock.cs
index afc3e48..2dc8a3b 100644
--- a/Novacoin/CBlock.cs
+++ b/Novacoin/CBlock.cs
@@ -21,7 +21,7 @@ using System.Text;
 using System.Collections.Generic;
 using System.Diagnostics.Contracts;
 using System.IO;
-using System.Numerics;
+using System.Numerics; // TODO: implement wrapper for BouncyCastle implementation of BigInteger and use it instead. This is necessary due to incompatibility of System.Numerics.BigInteger with OpenSSL.
 
 namespace Novacoin
 {