From: Wladimir J. van der Laan <laanwj@gmail.com>
Date: Mon, 8 Sep 2014 10:20:50 +0000 (+0200)
Subject: netbase: Use .data() instead of .c_str() on binary string
X-Git-Tag: nvc-v0.5.6~57^2~2
X-Git-Url: https://git.novaco.in/?p=novacoin.git;a=commitdiff_plain;h=5ae858b9cb5aa7815773fb067e5e1a7ffa07119e

netbase: Use .data() instead of .c_str() on binary string

`.c_str()` is only guaranteed to return the data up to the first NUL
character.
---

diff --git a/src/netbase.cpp b/src/netbase.cpp
index a9caddf..41dec48 100644
--- a/src/netbase.cpp
+++ b/src/netbase.cpp
@@ -252,7 +252,7 @@ bool static Socks5(string strDest, uint16_t port, SOCKET& hSocket)
     strSocks5 += strDest;
     strSocks5 += static_cast<char>((port >> 8) & 0xFF);
     strSocks5 += static_cast<char>((port >> 0) & 0xFF);
-    ret = send(hSocket, strSocks5.c_str(), strSocks5.size(), MSG_NOSIGNAL);
+    ret = send(hSocket, strSocks5.data(), strSocks5.size(), MSG_NOSIGNAL);
     if (ret != (ssize_t)strSocks5.size())
     {
         CloseSocket(hSocket);