From: Luke Dashjr <luke-jr+git@utopios.org>
Date: Fri, 4 May 2012 18:55:15 +0000 (+0000)
Subject: Merge branch '0.4.x' into 0.5.x
X-Git-Tag: v0.4.0-unstable~129^2~1^2^2~14^2~3
X-Git-Url: https://git.novaco.in/?p=novacoin.git;a=commitdiff_plain;h=b2e5f797b5670c4dc7d0dfd696d21977575fe9ed

Merge branch '0.4.x' into 0.5.x
---

b2e5f797b5670c4dc7d0dfd696d21977575fe9ed
diff --cc src/main.cpp
index 5f98d49,e8cbc01..ff4e2f0
--- a/src/main.cpp
+++ b/src/main.cpp
@@@ -1490,21 -1470,21 +1490,31 @@@ bool CBlock::CheckBlock() cons
      // Check transactions
      BOOST_FOREACH(const CTransaction& tx, vtx)
          if (!tx.CheckTransaction())
 -            return error("CheckBlock() : CheckTransaction failed");
 +            return DoS(tx.nDoS, error("CheckBlock() : CheckTransaction failed"));
 +
 +    // Check for duplicate txids. This is caught by ConnectInputs(),
 +    // but catching it earlier avoids a potential DoS attack:
 +    set<uint256> uniqueTx;
 +    BOOST_FOREACH(const CTransaction& tx, vtx)
 +    {
 +        uniqueTx.insert(tx.GetHash());
 +    }
 +    if (uniqueTx.size() != vtx.size())
 +        return DoS(100, error("CheckBlock() : duplicate transaction"));
  
+     // Check for duplicate txids. This is caught by ConnectInputs(),
+     // but catching it earlier avoids a potential DoS attack:
+     set<uint256> uniqueTx;
+     BOOST_FOREACH(const CTransaction& tx, vtx)
+     {
+         uniqueTx.insert(tx.GetHash());
+     }
+     if (uniqueTx.size() != vtx.size())
+         return error("CheckBlock() : duplicate transaction");
+ 
      // Check that it's not full of nonstandard transactions
      if (GetSigOpCount() > MAX_BLOCK_SIGOPS)
 -        return error("CheckBlock() : out-of-bounds SigOpCount");
 +        return DoS(100, error("CheckBlock() : out-of-bounds SigOpCount"));
  
      // Check merkleroot
      if (hashMerkleRoot != BuildMerkleTree())