From: Gregory Maxwell <greg@xiph.org>
Date: Thu, 10 Apr 2014 00:09:17 +0000 (-0700)
Subject: Correct some proxy related socket leaks.
X-Git-Tag: nvc-v0.5.3~29^2
X-Git-Url: https://git.novaco.in/?p=novacoin.git;a=commitdiff_plain;h=d1ddff624985647522d834c29ef9a484a53513bb

Correct some proxy related socket leaks.
---

diff --git a/src/netbase.cpp b/src/netbase.cpp
index 2df8ad7..744a5b0 100644
--- a/src/netbase.cpp
+++ b/src/netbase.cpp
@@ -298,8 +298,10 @@ bool static Socks5(string strDest, int port, SOCKET& hSocket)
         case 0x03:
         {
             ret = recv(hSocket, pchRet3, 1, 0) != 1;
-            if (ret)
+            if (ret) {
+                closesocket(hSocket);
                 return error("Error reading from proxy");
+            }
             int nRecv = pchRet3[0];
             ret = recv(hSocket, pchRet3, nRecv, 0) != nRecv;
             break;
@@ -506,6 +508,7 @@ bool ConnectSocket(const CService &addrDest, SOCKET& hSocketRet, int nTimeout)
             return false;
         break;
     default:
+        closesocket(hSocket);
         return false;
     }
 
@@ -537,7 +540,9 @@ bool ConnectSocketByName(CService &addr, SOCKET& hSocketRet, const char *pszDest
 
     switch(nameproxy.second) {
         default:
-        case 4: return false;
+        case 4:
+            closesocket(hSocket);
+            return false;
         case 5:
             if (!Socks5(strDest, port, hSocket))
                 return false;