From 7bd596affe6c5888e0005cc6470f16b60e810d31 Mon Sep 17 00:00:00 2001 From: fsb4000 Date: Sun, 11 Jan 2015 14:15:29 +0600 Subject: [PATCH] OpenSSL fix https://github.com/bitcoin/bitcoin/pull/5634 --- src/key.cpp | 18 +++++++++++++++--- 1 files changed, 15 insertions(+), 3 deletions(-) diff --git a/src/key.cpp b/src/key.cpp index ed04e0e..1b3f380 100644 --- a/src/key.cpp +++ b/src/key.cpp @@ -449,11 +449,23 @@ bool CKey::SetCompactSignature(uint256 hash, const std::vector& v bool CKey::Verify(uint256 hash, const std::vector& vchSig) { - // -1 = error, 0 = bad sig, 1 = good - if (ECDSA_verify(0, (unsigned char*)&hash, sizeof(hash), &vchSig[0], vchSig.size(), pkey) != 1) + if (vchSig.empty()) return false; - return true; + // New versions of OpenSSL will reject non-canonical DER signatures. de/re-serialize first. + unsigned char *norm_der = NULL; + ECDSA_SIG *norm_sig = ECDSA_SIG_new(); + const unsigned char* sigptr = &vchSig[0]; + d2i_ECDSA_SIG(&norm_sig, &sigptr, vchSig.size()); + int derlen = i2d_ECDSA_SIG(norm_sig, &norm_der); + ECDSA_SIG_free(norm_sig); + if (derlen <= 0) + return false; + + // -1 = error, 0 = bad sig, 1 = good + bool ret = ECDSA_verify(0, (unsigned char*)&hash, sizeof(hash), norm_der, derlen, pkey) == 1; + OPENSSL_free(norm_der); + return ret; } bool CKey::VerifyCompact(uint256 hash, const std::vector& vchSig) -- 1.7.1