From be8651dde7b59e50e8c443da71c706667803d06d Mon Sep 17 00:00:00 2001 From: Gavin Andresen Date: Sun, 29 Apr 2012 20:56:55 -0400 Subject: [PATCH] Check earlier for blocks with duplicate transactions. Fixes #1167 --- src/main.cpp | 10 ++++++++++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/src/main.cpp b/src/main.cpp index e5d110d..427e435 100644 --- a/src/main.cpp +++ b/src/main.cpp @@ -1652,6 +1652,16 @@ bool CBlock::CheckBlock() const if (!tx.CheckTransaction()) return DoS(tx.nDoS, error("CheckBlock() : CheckTransaction failed")); + // Check for duplicate txids. This is caught by ConnectInputs(), + // but catching it earlier avoids a potential DoS attack: + set uniqueTx; + BOOST_FOREACH(const CTransaction& tx, vtx) + { + uniqueTx.insert(tx.GetHash()); + } + if (uniqueTx.size() != vtx.size()) + return DoS(100, error("CheckBlock() : duplicate transaction")); + unsigned int nSigOps = 0; BOOST_FOREACH(const CTransaction& tx, vtx) { -- 1.7.1