From c328c684c27b8a4e45c169cdcf4f003e7d9e976d Mon Sep 17 00:00:00 2001 From: Luke Dashjr Date: Fri, 4 May 2012 19:54:24 +0000 Subject: [PATCH] Bugfix: Remove redundant duplicate transaction check --- src/main.cpp | 10 ---------- 1 files changed, 0 insertions(+), 10 deletions(-) diff --git a/src/main.cpp b/src/main.cpp index ff4e2f0..5f98d49 100644 --- a/src/main.cpp +++ b/src/main.cpp @@ -1502,16 +1502,6 @@ bool CBlock::CheckBlock() const if (uniqueTx.size() != vtx.size()) return DoS(100, error("CheckBlock() : duplicate transaction")); - // Check for duplicate txids. This is caught by ConnectInputs(), - // but catching it earlier avoids a potential DoS attack: - set uniqueTx; - BOOST_FOREACH(const CTransaction& tx, vtx) - { - uniqueTx.insert(tx.GetHash()); - } - if (uniqueTx.size() != vtx.size()) - return error("CheckBlock() : duplicate transaction"); - // Check that it's not full of nonstandard transactions if (GetSigOpCount() > MAX_BLOCK_SIGOPS) return DoS(100, error("CheckBlock() : out-of-bounds SigOpCount")); -- 1.7.1