+/**
+ * Novacoin classes library
+ * Copyright (C) 2015 Alex D. (balthazar.ad@gmail.com)
+
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as
+ * published by the Free Software Foundation, either version 3 of the
+ * License, or (at your option) any later version.
+
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU Affero General Public License for more details.
+
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program. If not, see <http://www.gnu.org/licenses/>.
+ */
+
using System;
using System.Collections.Generic;
using System.Linq;
-using System.Text;
-
using System.Numerics;
-
-// using Org.BouncyCastle.Math;
+using System.Text;
namespace Novacoin
{
/// <summary>
- /// Script opcodes
+ /// Script instructions
/// </summary>
public enum instruction
{
}
/// <summary>
- /// Get the name of supplied opcode
+ /// Get the name of instruction
/// </summary>
- /// <param name="opcode">Opcode</param>
- /// <returns>Opcode name</returns>
+ /// <param name="opcode">Instruction</param>
+ /// <returns>Instruction name</returns>
public static string GetOpName(instruction opcode)
{
if (opcode == instruction.OP_0) // OP_0 and OP_FALSE are synonyms
}
/// <summary>
- /// Get next opcode from passed list of bytes and extract push arguments if there are some.
+ /// Get next instruction from list of bytes and extract push arguments if there are some.
/// </summary>
/// <param name="codeBytes">ByteQueue reference.</param>
- /// <param name="opcodeRet">Found opcode.</param>
+ /// <param name="opcodeRet">Found instruction.</param>
/// <param name="bytesRet">IEnumerable out param which is used to get the push arguments.</param>
/// <returns>Result of operation</returns>
- public static bool GetOp(ref ByteQueue codeBytes, out instruction opcodeRet, out IEnumerable<byte> bytesRet)
+ public static bool GetOp(ref ByteQueue codeBytes, out instruction opcodeRet, out byte[] bytesRet)
{
- bytesRet = new List<byte>();
+ bytesRet = new byte[0];
opcodeRet = instruction.OP_INVALIDOPCODE;
instruction opcode;
{
if (opcode < instruction.OP_PUSHDATA1)
{
- // Zero value opcodes (OP_0, OP_FALSE)
+ // Zero value instructions (OP_0, OP_FALSE)
szBytes[3] = (byte)opcode;
}
else if (opcode == instruction.OP_PUSHDATA1)
{
// The next byte contains the number of bytes to be pushed onto the stack,
// i.e. you have something like OP_PUSHDATA1 0x01 [0x5a]
- szBytes[3] = (byte)codeBytes.Get();
+ szBytes[3] = codeBytes.Get();
}
else if (opcode == instruction.OP_PUSHDATA2)
{
try
{
// Read found number of bytes into list of OP_PUSHDATAn arguments.
- bytesRet = codeBytes.GetEnumerable(nSize);
+ bytesRet = codeBytes.Get(nSize);
}
catch (ByteQueueException)
{
/// </summary>
/// <param name="bytes">Collection of value bytes.</param>
/// <returns>Formatted value.</returns>
- public static string ValueString(IEnumerable<byte> bytes)
+ public static string ValueString(byte[] bytes)
{
- StringBuilder sb = new StringBuilder();
+ var sb = new StringBuilder();
- if (bytes.Count() <= 4)
+ if (bytes.Length <= 4)
{
- byte[] valueBytes = new byte[4] { 0, 0, 0, 0 };
- bytes.ToArray().CopyTo(valueBytes, valueBytes.Length - bytes.Count());
-
- sb.Append(Interop.BEBytesToUInt32(valueBytes));
+ sb.Append(Interop.BEBytesToUInt32(bytes));
}
else
{
/// </summary>
/// <param name="stackList">List of stack items.</param>
/// <returns>Formatted value.</returns>
- public static string StackString(IList<IList<byte>> stackList)
+ public static string StackString(IList<byte[]> stackList)
{
- StringBuilder sb = new StringBuilder();
- foreach (IList<byte> bytesList in stackList)
+ var sb = new StringBuilder();
+ foreach (var bytes in stackList)
{
- sb.Append(ValueString(bytesList));
+ sb.Append(ValueString(bytes));
}
return sb.ToString();
/// <summary>
/// Decode instruction to integer value
/// </summary>
- /// <param name="opcode">Small integer opcode (OP_1_NEGATE and OP_0 - OP_16)</param>
+ /// <param name="opcode">Small integer instruction (OP_1_NEGATE and OP_0 - OP_16)</param>
/// <returns>Small integer</returns>
public static int DecodeOP_N(instruction opcode, bool AllowNegate = false)
{
return 0;
}
- // Only OP_n opcodes are supported, throw exception otherwise.
+ // Only OP_n instructions are supported, throw exception otherwise.
if (opcode < instruction.OP_1 || opcode > instruction.OP_16)
{
throw new ArgumentException("Invalid integer instruction.");
/// Converts integer into instruction
/// </summary>
/// <param name="n">Small integer from the range of -1 up to 16.</param>
- /// <returns>Corresponding opcode.</returns>
+ /// <returns>Corresponding instruction.</returns>
public static instruction EncodeOP_N(int n, bool allowNegate = false)
{
if (allowNegate && n == -1)
return (instruction.OP_1 + n - 1);
}
- public static int ScriptSigArgsExpected(txnouttype t, IList<IEnumerable<byte>> solutions)
+ public static int ScriptSigArgsExpected(txnouttype t, IList<byte[]> solutions)
{
switch (t)
{
case txnouttype.TX_PUBKEYHASH:
return 2;
case txnouttype.TX_MULTISIG:
- if (solutions.Count() < 1 || solutions.First().Count() < 1)
+ if (solutions.Count < 1 || solutions.First().Length < 1)
return -1;
- return solutions.First().First() + 1;
+ return solutions.First()[0] + 1;
case txnouttype.TX_SCRIPTHASH:
return 1; // doesn't include args needed by the script
}
/// <returns>Checking result</returns>
public static bool IsStandard(CScript scriptPubKey, out txnouttype whichType)
{
- IList<IEnumerable<byte>> solutions = new List<IEnumerable<byte>>();
+ IList<byte[]> solutions;
if (!Solver(scriptPubKey, out whichType, out solutions))
{
if (whichType == txnouttype.TX_MULTISIG)
{
// Additional verification of OP_CHECKMULTISIG arguments
- byte m = solutions.First().First();
- byte n = solutions.Last().First();
+ var m = solutions.First()[0];
+ var n = solutions.Last()[0];
// Support up to x-of-3 multisig txns as standard
if (n < 1 || n > 3)
/// <param name="typeRet">Output type</param>
/// <param name="solutions">Set of solutions</param>
/// <returns>Result</returns>
- public static bool Solver(CScript scriptPubKey, out txnouttype typeRet, out IList<IEnumerable<byte>> solutions)
+ public static bool Solver(CScript scriptPubKey, out txnouttype typeRet, out IList<byte[]> solutions)
{
- solutions = new List<IEnumerable<byte>>();
+ solutions = new List<byte[]>();
// There are shortcuts for pay-to-script-hash and pay-to-pubkey-hash, which are more constrained than the other types.
typeRet = txnouttype.TX_SCRIPTHASH;
// Take 20 bytes with offset of 2 bytes
- IEnumerable<byte> hashBytes = scriptPubKey.Bytes.Skip(2).Take(20);
- solutions.Add(hashBytes);
+ var hashBytes = scriptPubKey.Bytes.Skip(2).Take(20);
+ solutions.Add(hashBytes.ToArray());
return true;
}
typeRet = txnouttype.TX_PUBKEYHASH;
// Take 20 bytes with offset of 3 bytes
- IEnumerable<byte> hashBytes = scriptPubKey.Bytes.Skip(3).Take(20);
- solutions.Add(hashBytes);
+ var hashBytes = scriptPubKey.Bytes.Skip(3).Take(20);
+ solutions.Add(hashBytes.ToArray());
return true;
}
- List<Tuple<txnouttype, IEnumerable<byte>>> templateTuples = new List<Tuple<txnouttype, IEnumerable<byte>>>();
+ var templateTuples = new List<Tuple<txnouttype, byte[]>>();
// Sender provides pubkey, receiver adds signature
// [ECDSA public key] OP_CHECKSIG
templateTuples.Add(
- new Tuple<txnouttype, IEnumerable<byte>>(
+ new Tuple<txnouttype, byte[]>(
txnouttype.TX_PUBKEY,
new byte[] {
(byte)instruction.OP_PUBKEY,
// Sender provides N pubkeys, receivers provides M signatures
// N [pubkey1] [pubkey2] ... [pubkeyN] M OP_CHECKMULTISIG
- // Where N and M are small integer opcodes (OP1 ... OP_16)
+ // Where N and M are small integer instructions (OP1 ... OP_16)
templateTuples.Add(
- new Tuple<txnouttype, IEnumerable<byte>>(
+ new Tuple<txnouttype, byte[]>(
txnouttype.TX_MULTISIG,
new byte[] {
(byte)instruction.OP_SMALLINTEGER,
// Data-carrying output
// OP_RETURN [up to 80 bytes of data]
templateTuples.Add(
- new Tuple<txnouttype, IEnumerable<byte>>(
+ new Tuple<txnouttype, byte[]>(
txnouttype.TX_NULL_DATA,
new byte[] {
(byte)instruction.OP_RETURN,
// Nonstandard tx output
typeRet = txnouttype.TX_NONSTANDARD;
- foreach (Tuple<txnouttype, IEnumerable<byte>> templateTuple in templateTuples)
+ foreach (var templateTuple in templateTuples)
{
- CScript script1 = scriptPubKey;
- CScript script2 = new CScript(templateTuple.Item2);
+ var script1 = scriptPubKey;
+ var script2 = new CScript(templateTuple.Item2);
instruction opcode1, opcode2;
// Compare
- ByteQueue bq1 = script1.GetByteQUeue();
- ByteQueue bq2 = script2.GetByteQUeue();
+ var bq1 = script1.GetByteQUeue();
+ var bq2 = script2.GetByteQUeue();
- IEnumerable<byte> args1, args2;
+ byte[] args1, args2;
int last1 = script1.Bytes.Count() -1;
int last2 = script2.Bytes.Count() - 1;
if (typeRet == txnouttype.TX_MULTISIG)
{
// Additional checks for TX_MULTISIG:
- byte m = solutions.First().First();
- byte n = solutions.Last().First();
+ var m = solutions.First().First();
+ var n = solutions.Last().First();
if (m < 1 || n < 1 || m > n || solutions.Count - 2 != n)
{
break;
}
- // Template matching opcodes:
+ // Template matching instructions:
if (opcode2 == instruction.OP_PUBKEYS)
{
while (args1.Count() >= 33 && args1.Count() <= 120)
// Single-byte small integer pushed onto solutions
try
{
- byte n = (byte)DecodeOP_N(opcode1);
+ var n = (byte)DecodeOP_N(opcode1);
solutions.Add(new byte[] { n });
}
catch (Exception)
else if (opcode2 == instruction.OP_SMALLDATA)
{
// small pushdata, <= 80 bytes
- if (args1.Count() > 80)
+ if (args1.Length > 80)
{
break;
}
{
if (nIn >= txTo.vin.Length)
{
- StringBuilder sb = new StringBuilder();
+ var sb = new StringBuilder();
sb.AppendFormat("ERROR: SignatureHash() : nIn={0} out of range\n", nIn);
throw new ArgumentOutOfRangeException("nIn", sb.ToString());
}
// Init a copy of transaction
- CTransaction txTmp = new CTransaction(txTo);
+ var txTmp = new CTransaction(txTo);
// In case concatenating two scripts ends up with two codeseparators,
// or an extra one at the end, this prevents all those possible incompatibilities.
Array.Resize(ref txTmp.vin, 1);
}
- // Serialize and hash
- List<byte> b = new List<byte>();
- b.AddRange(txTmp.Bytes);
- b.AddRange(BitConverter.GetBytes(nHashType));
+ // Concatenate and hash
+ var txBytes = txTmp.Bytes;
+ var nHashTypeBytes = BitConverter.GetBytes(nHashType);
- return Hash256.Compute256(b);
+ return Hash256.Compute256(ref txBytes, ref nHashTypeBytes);
}
//
/// Remove last element from stack
/// </summary>
/// <param name="stack">Stack reference</param>
- private static void popstack(ref List<IEnumerable<byte>> stack)
+ private static void popstack(ref List<byte[]> stack)
{
int nCount = stack.Count;
if (nCount == 0)
/// <param name="stack">Stack reference</param>
/// <param name="nDepth">Depth</param>
/// <returns>Byte sequence</returns>
- private static IEnumerable<byte> stacktop(ref List<IEnumerable<byte>> stack, int nDepth)
+ private static byte[] stacktop(ref List<byte[]> stack, int nDepth)
{
int nStackElement = stack.Count + nDepth;
/// </summary>
/// <param name="value">Some byte sequence</param>
/// <returns></returns>
- private static bool CastToBool(IEnumerable<byte> arg)
+ private static bool CastToBool(byte[] arg)
{
- byte[] value = arg.ToArray();
-
- for (var i = 0; i < value.Length; i++)
+ for (var i = 0; i < arg.Length; i++)
{
- if (value[i] != 0)
+ if (arg[i] != 0)
{
// Can be negative zero
- if (i == value.Length - 1 && value[i] == 0x80)
+ if (i == arg.Length - 1 && arg[i] == 0x80)
{
return false;
}
/// </summary>
/// <param name="value"></param>
/// <returns></returns>
- private static BigInteger CastToBigInteger(IEnumerable<byte> value)
+ private static BigInteger CastToBigInteger(byte[] value)
{
- if (value.Count() > 4)
+ if (value.Length > 4)
{
throw new StackMachineException("CastToBigInteger() : overflow");
}
- return new BigInteger(value.ToArray());
+ return new BigInteger(value);
}
/// <summary>
/// <param name="flags">Signature checking flags</param>
/// <param name="nHashType">Hash type flag</param>
/// <returns></returns>
- public static bool EvalScript(ref List<IEnumerable<byte>> stack, CScript script, CTransaction txTo, int nIn, int flags, int nHashType)
+ public static bool EvalScript(ref List<byte[]> stack, CScript script, CTransaction txTo, int nIn, int flags, int nHashType)
{
if (script.Bytes.Count() > 10000)
{
return false; // Size limit failed
}
- List<bool> vfExec = new List<bool>();
+ var vfExec = new List<bool>();
int nOpCount = 0;
int nCodeHashBegin = 0;
- byte[] falseBytes = new byte[0];
- byte[] trueBytes = new byte[] { 0x01 };
+ var falseBytes = new byte[0];
+ var trueBytes = new byte[] { 0x01 };
- ByteQueue CodeQueue = script.GetByteQUeue();
- List<IEnumerable<byte>> altStack = new List<IEnumerable<byte>>();
+ var CodeQueue = script.GetByteQUeue();
+ var altStack = new List<byte[]>();
try
{
instruction opcode;
- IEnumerable<byte> pushArg;
+ byte[] pushArg;
while (GetOp(ref CodeQueue, out opcode, out pushArg)) // Read instructions
{
bool fExec = vfExec.IndexOf(false) == -1;
- if (pushArg.Count() > 520)
+ if (pushArg.Length > 520)
{
return false; // Script element size limit failed
}
switch (opcode)
{
//
- // Disabled opcodes
+ // Disabled instructions
//
case instruction.OP_CAT:
case instruction.OP_SUBSTR:
case instruction.OP_NOTIF:
{
// <expression> if [statements] [else [statements]] endif
- bool fValue = false;
+ var fValue = false;
if (fExec)
{
if (stack.Count() < 1)
{
return false;
}
- IEnumerable<byte> vch = stacktop(ref stack, -1);
+ var vch = stacktop(ref stack, -1);
fValue = CastToBool(vch);
if (opcode == instruction.OP_NOTIF)
{
{
return false;
}
- IEnumerable<byte> vch1 = stacktop(ref stack, -2);
- IEnumerable<byte> vch2 = stacktop(ref stack, -1);
+ var vch1 = stacktop(ref stack, -2);
+ var vch2 = stacktop(ref stack, -1);
stack.Add(vch1);
stack.Add(vch2);
}
{
return false;
}
- IEnumerable<byte> vch1 = stacktop(ref stack, -3);
- IEnumerable<byte> vch2 = stacktop(ref stack, -2);
- IEnumerable<byte> vch3 = stacktop(ref stack, -1);
+ var vch1 = stacktop(ref stack, -3);
+ var vch2 = stacktop(ref stack, -2);
+ var vch3 = stacktop(ref stack, -1);
stack.Add(vch1);
stack.Add(vch2);
stack.Add(vch3);
{
return false;
}
- IEnumerable<byte> vch1 = stacktop(ref stack, -4);
- IEnumerable<byte> vch2 = stacktop(ref stack, -3);
+ var vch1 = stacktop(ref stack, -4);
+ var vch2 = stacktop(ref stack, -3);
stack.Add(vch1);
stack.Add(vch2);
}
{
return false;
}
- IEnumerable<byte> vch1 = stacktop(ref stack, -6);
- IEnumerable<byte> vch2 = stacktop(ref stack, -5);
+ var vch1 = stacktop(ref stack, -6);
+ var vch2 = stacktop(ref stack, -5);
stack.RemoveRange(nStackDepth - 6, 2);
stack.Add(vch1);
stack.Add(vch2);
case instruction.OP_2SWAP:
{
// (x1 x2 x3 x4 -- x3 x4 x1 x2)
- int nStackDepth = stack.Count();
+ int nStackDepth = stack.Count;
if (nStackDepth < 4)
{
return false;
return false;
}
- IEnumerable<byte> vch = stacktop(ref stack, -1);
+ var vch = stacktop(ref stack, -1);
if (CastToBool(vch))
{
return false;
}
- IEnumerable<byte> vch = stacktop(ref stack, -1);
+ var vch = stacktop(ref stack, -1);
stack.Add(vch);
}
break;
return false;
}
- IEnumerable<byte> vch = stacktop(ref stack, -2);
+ var vch = stacktop(ref stack, -2);
stack.Add(vch);
}
break;
return false;
}
- IEnumerable<byte> vch = stacktop(ref stack, -n - 1);
+ var vch = stacktop(ref stack, -n - 1);
if (opcode == instruction.OP_ROLL)
{
stack.RemoveAt(nStackDepth - n - 1);
{
return false;
}
- IEnumerable<byte> vch = stacktop(ref stack, -1);
+ var vch = stacktop(ref stack, -1);
stack.Insert(nStackDepth - 2, vch);
}
break;
return false;
}
- BigInteger bnSize = new BigInteger((ushort)stacktop(ref stack, -1).Count());
+ var bnSize = new BigInteger((ushort)stacktop(ref stack, -1).Count());
stack.Add(bnSize.ToByteArray());
}
break;
return false;
}
- IEnumerable<byte> vch1 = stacktop(ref stack, -2);
- IEnumerable<byte> vch2 = stacktop(ref stack, -1);
- bool fEqual = (vch1 == vch2);
+ var vch1 = stacktop(ref stack, -2);
+ var vch2 = stacktop(ref stack, -1);
+ bool fEqual = (vch1.SequenceEqual(vch2));
// OP_NOTEQUAL is disabled because it would be too easy to say
// something like n != 1 and have some wiseguy pass in 1 with extra
// zero bytes after it (numerically, 0x01 == 0x0001 == 0x000001)
return false;
}
- BigInteger bn = CastToBigInteger(stacktop(ref stack, -1));
+ var bn = CastToBigInteger(stacktop(ref stack, -1));
switch (opcode)
{
case instruction.OP_1ADD:
return false;
}
- BigInteger bn1 = CastToBigInteger(stacktop(ref stack, -2));
- BigInteger bn2 = CastToBigInteger(stacktop(ref stack, -1));
+ var bn1 = CastToBigInteger(stacktop(ref stack, -2));
+ var bn2 = CastToBigInteger(stacktop(ref stack, -1));
BigInteger bn = 0;
switch (opcode)
return false;
}
- BigInteger bn1 = CastToBigInteger(stacktop(ref stack, -3));
- BigInteger bn2 = CastToBigInteger(stacktop(ref stack, -2));
- BigInteger bn3 = CastToBigInteger(stacktop(ref stack, -1));
+ var bn1 = CastToBigInteger(stacktop(ref stack, -3));
+ var bn2 = CastToBigInteger(stacktop(ref stack, -2));
+ var bn3 = CastToBigInteger(stacktop(ref stack, -1));
bool fValue = (bn2 <= bn1 && bn1 < bn3);
return false;
}
Hash hash = null;
- IEnumerable<byte> data = stacktop(ref stack, -1);
+ var data = stacktop(ref stack, -1);
switch (opcode)
{
return false;
}
- IList<byte> sigBytes = stacktop(ref stack, -2).ToList();
- IList<byte> pubkeyBytes = stacktop(ref stack, -1).ToList();
+ byte[] sigBytes = stacktop(ref stack, -2);
+ byte[] pubkeyBytes = stacktop(ref stack, -1);
// Subset of script starting at the most recent codeseparator
CScript scriptCode = new CScript(script.Bytes.Skip(nCodeHashBegin));
// There's no way for a signature to sign itself
scriptCode.RemovePattern(sigBytes);
- bool fSuccess = IsCanonicalSignature(sigBytes, flags) && IsCanonicalPubKey(pubkeyBytes.ToList(), flags) && CheckSig(sigBytes, pubkeyBytes, scriptCode, txTo, nIn, nHashType, flags);
+ bool fSuccess = IsCanonicalSignature(sigBytes, flags) && IsCanonicalPubKey(pubkeyBytes, flags) && CheckSig(sigBytes, pubkeyBytes, scriptCode, txTo, nIn, nHashType, flags);
popstack(ref stack);
popstack(ref stack);
// There is no way for a signature to sign itself, so we need to drop the signatures
for (int k = 0; k < nSigsCount; k++)
{
- IEnumerable<byte> vchSig = stacktop(ref stack, -isig - k);
- scriptCode.RemovePattern(vchSig.ToList());
+ var vchSig = stacktop(ref stack, -isig - k);
+ scriptCode.RemovePattern(vchSig);
}
bool fSuccess = true;
while (fSuccess && nSigsCount > 0)
{
- IList<byte> sigBytes = stacktop(ref stack, -isig).ToList();
- IList<byte> pubKeyBytes = stacktop(ref stack, -ikey).ToList();
+ var sigBytes = stacktop(ref stack, -isig);
+ var pubKeyBytes = stacktop(ref stack, -ikey);
// Check signature
- bool fOk = IsCanonicalSignature(sigBytes, flags) && IsCanonicalPubKey(pubKeyBytes.ToList(), flags) && CheckSig(sigBytes, pubKeyBytes, scriptCode, txTo, nIn, nHashType, flags);
+ bool fOk = IsCanonicalSignature(sigBytes, flags) && IsCanonicalPubKey(pubKeyBytes, flags) && CheckSig(sigBytes, pubKeyBytes, scriptCode, txTo, nIn, nHashType, flags);
if (fOk)
{
}
- public static bool IsCanonicalPubKey(IList<byte> pubKeyBytes, int flags)
+ public static bool IsCanonicalPubKey(byte[] pubKeyBytes, int flags)
{
if ((flags & (int)scriptflag.SCRIPT_VERIFY_STRICTENC) == 0)
return true;
- if (pubKeyBytes.Count < 33)
+ if (pubKeyBytes.Length < 33)
return false; // Non-canonical public key: too short
if (pubKeyBytes[0] == 0x04)
{
- if (pubKeyBytes.Count != 65)
+ if (pubKeyBytes.Length != 65)
return false; // Non-canonical public key: invalid length for uncompressed key
}
else if (pubKeyBytes[0] == 0x02 || pubKeyBytes[0] == 0x03)
{
- if (pubKeyBytes.Count != 33)
+ if (pubKeyBytes.Length != 33)
return false; // Non-canonical public key: invalid length for compressed key
}
else
return true;
}
- public static bool IsCanonicalSignature(IList<byte> sigBytes, int flags)
+ public static bool IsCanonicalSignature(byte[] sigBytes, int flags)
{
// STUB
/// <param name="nHashType">Hashing type flag</param>
/// <param name="flags">Signature checking flags</param>
/// <returns>Checking result</returns>
- public static bool CheckSig(IList<byte> sigBytes, IList<byte> pubkeyBytes, CScript script, CTransaction txTo, int nIn, int nHashType, int flags)
+ public static bool CheckSig(byte[] sigBytes, byte[] pubkeyBytes, CScript script, CTransaction txTo, int nIn, int nHashType, int flags)
{
CPubKey pubkey;
return false;
}
- if (sigBytes.Count == 0)
+ if (sigBytes.Length == 0)
{
return false;
}
}
// Remove hash type
- sigBytes.RemoveAt(sigBytes.Count - 1);
+ Array.Resize(ref sigBytes, sigBytes.Length - 1);
- Hash256 sighash = SignatureHash(script, txTo, nIn, nHashType);
+ var sighash = SignatureHash(script, txTo, nIn, nHashType);
if (!pubkey.VerifySignature(sighash, sigBytes))
{
/// <returns></returns>
public static bool VerifyScript(CScript scriptSig, CScript scriptPubKey, CTransaction txTo, int nIn, int flags, int nHashType)
{
- List<IEnumerable<byte>> stack = new List<IEnumerable<byte>>();
- List<IEnumerable<byte>> stackCopy = null;
+ var stack = new List<byte[]>();
+ List<byte[]> stackCopy = null;
if (!EvalScript(ref stack, scriptSig, txTo, nIn, flags, nHashType))
{
if ((flags & (int)scriptflag.SCRIPT_VERIFY_P2SH) != 0)
{
- stackCopy = new List<IEnumerable<byte>> (stack);
+ stackCopy = new List<byte[]>(stack);
}
if (!EvalScript(ref stack, scriptPubKey, txTo, nIn, flags, nHashType))
throw new StackMachineException("Fatal script validation error.");
}
- CScript pubKey2 = new CScript(stackCopy.Last());
+ var pubKey2 = new CScript(stackCopy.Last());
popstack(ref stackCopy);
if (!EvalScript(ref stackCopy, pubKey2, txTo, nIn, flags, nHashType))
git://git.novaco.in / NovacoinLibrary.git / blobdiff