Wladimir J. van der Laan [Sat, 21 Apr 2012 16:21:19 +0000]
Remove no-longer used UI hints in bitcoin core
The Qt UI has its own associated structures for temporary transaction state / cache.
Wladimir J. van der Laan [Sat, 21 Apr 2012 11:31:08 +0000]
change type of various bare chars to bool that are only used as bool (and never serialized)
Wladimir J. van der Laan [Sat, 21 Apr 2012 08:10:48 +0000]
Add explicit numeric constant value for all opcodes
- Easier for debugging (what opcode was 0x... again?)
- Clarifies that the opcodes are set in stone in the protocol, and signals that it is impossible to insert opcodes in between.
Wladimir J. van der Laan [Fri, 20 Apr 2012 17:18:45 +0000]
Merge pull request #1122 from dlitz/unsigned-char-fix
Unsigned char fix & fix undefined phexdigits[255]
Pieter Wuille [Thu, 19 Apr 2012 11:33:04 +0000]
Merge pull request #959 from rebroad/LoadBlockIndexKillable
Added ability to respond to signals during Block Loading stage.
R E Broadley [Wed, 18 Apr 2012 11:30:24 +0000]
Added ability to respond to signals during Block Loading stage.
Dwayne C. Litzenberger [Mon, 16 Apr 2012 05:32:55 +0000]
Fix bugs on 'unsigned char' platforms.
In ISO C++, the signedness of 'char' is undefined. On some platforms (e.g.
ARM), 'char' is an unsigned type, but some of the code relies on 'char' being
signed (as it is on x86). This is indicated by compiler warnings like this:
bignum.h: In constructor 'CBigNum::CBigNum(char)':
bignum.h:81:59: warning: comparison is always true due to limited range of data type [-Wtype-limits]
util.cpp: In function 'bool IsHex(const string&)':
util.cpp:427:28: warning: comparison is always false due to limited range of data type [-Wtype-limits]
In particular, IsHex erroneously returned true regardless of the input
characters, as long as the length of the string was a positive multiple of 2.
Note: For testing, it's possible using GCC to force char to be unsigned by
adding the -funsigned-char parameter to xCXXFLAGS.
Dwayne C. Litzenberger [Mon, 16 Apr 2012 05:31:38 +0000]
Fix phexdigits[255] is undefined.
Wladimir J. van der Laan [Tue, 17 Apr 2012 21:33:26 +0000]
Merge pull request #1118 from sipa/addbreaks
Add missing breaks in optionmodel's switch case
Pieter Wuille [Tue, 17 Apr 2012 21:27:59 +0000]
Add missing breaks in optionmodel's switch case
Pieter Wuille [Tue, 17 Apr 2012 21:23:31 +0000]
Merge pull request #1114 from sipa/lesssync
Reduce sync frequency for blkindex.dat
Pieter Wuille [Tue, 17 Apr 2012 18:37:47 +0000]
Fix tests after recent refactors
Pieter Wuille [Tue, 17 Apr 2012 18:12:48 +0000]
Merge remote-tracking branch 'jgarzik/mempool'
Pieter Wuille [Tue, 17 Apr 2012 18:05:02 +0000]
Merge pull request #1117 from sipa/deadlockfix
Fix potential deadlock
Pieter Wuille [Tue, 17 Apr 2012 18:04:29 +0000]
Merge pull request #1112 from sipa/saneserial
Further reduce header dependencies
Pieter Wuille [Mon, 16 Apr 2012 12:56:45 +0000]
Further reduce header dependencies
This commit removes the dependency of serialize.h on PROTOCOL_VERSION,
and makes this parameter required instead of implicit. This is much saner,
as it makes the places where changing a version number can have an
influence obvious.
Jeff Garzik [Sun, 15 Apr 2012 22:20:05 +0000]
Move proto version to version.h. Reduce header deps a bit more.
Jeff Garzik [Sun, 15 Apr 2012 21:39:49 +0000]
Move CWalletDB code to new walletdb module.
In addition to standard code separation, this change opens the door
to fixing several include inter-dependencies.
Pieter Wuille [Sun, 15 Apr 2012 20:10:54 +0000]
Remove headers.h
Gavin Andresen [Tue, 17 Apr 2012 17:55:56 +0000]
Merge pull request #1106 from jgarzik/sign-compare
Fix many sign-comparison warnings found in bitcoin codebase
Gavin Andresen [Tue, 17 Apr 2012 17:12:33 +0000]
Merge pull request #1115 from laanwj/2012_04_cleanupmisc
Delete unused, unreachable and commented code, add missing initializer
Pieter Wuille [Tue, 17 Apr 2012 16:50:45 +0000]
Fix potential deadlock
Conflict:
* cs_main in ProcessMessages() (before calling ProcessMessages)
* cs_vSend in CNode::BeginMessage
versus:
* cs_vSend in ThreadMessageHandler2 (before calling SendMessages)
* cs_main in SendMessages
Even though cs_vSend is a try_lock, if it succeeds simultaneously with
the locking of cs_main in ProcessMessages(), it could cause a deadlock.
Jeff Garzik [Tue, 17 Apr 2012 16:31:51 +0000]
main.cpp: replace tabs with spaces
Sometimes they sneak in through the 'vi' door
Jeff Garzik [Tue, 17 Apr 2012 16:30:00 +0000]
AlreadyHave(): only hold lock during mapTransactions access
Wladimir J. van der Laan [Mon, 16 Apr 2012 09:44:05 +0000]
Remove unused and unreachable code
Wladimir J. van der Laan [Mon, 16 Apr 2012 09:46:13 +0000]
Add forgotten initializer
Pieter Wuille [Tue, 17 Apr 2012 16:27:00 +0000]
Reduce sync frequency for blkindex.dat
Since auto-remove-db-logs was enabled, each time a CTxDB was closed
outside of the initial download window, it causes a checkpoint + log
cleanup. This is overkill, so reduce the sync frequency to once per
minute at most.
Jeff Garzik [Tue, 17 Apr 2012 16:23:49 +0000]
Merge pull request #1094 from jgarzik/already-have-locking
Locking fix for AlreadyHave()
Jeff Garzik [Tue, 17 Apr 2012 16:16:46 +0000]
Bump PROTOCOL_VERSION to 60001, thereby enabling BIP31
Jeff Garzik [Tue, 17 Apr 2012 15:51:17 +0000]
Merge pull request #1081 from jgarzik/pong
BIP 0031: pong message
Wladimir J. van der Laan [Mon, 16 Apr 2012 12:41:39 +0000]
Merge pull request #1092 from laanwj/2012_04_sendcoins_setlabelfix
When sending coins, set label when selecting address that already has a label
Wladimir J. van der Laan [Mon, 16 Apr 2012 07:55:37 +0000]
Merge pull request #1091 from Diapolo/GUI-BlockDL
revert to default OS theme for progressbar (fix #1071)
Jeff Garzik [Sun, 15 Apr 2012 21:00:20 +0000]
Fix misc. minor sign-comparison warnings
Jeff Garzik [Sun, 15 Apr 2012 20:59:48 +0000]
CNode's nHeaderStart may be negative, so change its type
Jeff Garzik [Sun, 15 Apr 2012 20:59:09 +0000]
serialize.h: CAutoFile's read and write may take size_t nSize
Jeff Garzik [Sun, 15 Apr 2012 20:58:32 +0000]
Fix sign-compare warnings: netbase's Lookup* max-solutions may be unsigned
Jeff Garzik [Sun, 15 Apr 2012 20:52:09 +0000]
Fix loop index var types, fixing many minor sign comparison warnings
foo.size() typically returns an unsigned integral type; make loop variables
match those types' signedness.
Jeff Garzik [Sun, 15 Apr 2012 20:47:24 +0000]
The string class returns string::npos, when find() fails.
Noticed when sign-comparison warnings were enabled.
Jeff Garzik [Fri, 13 Apr 2012 22:20:44 +0000]
CTxMemPool: add helper methods, to reduce global mempool.mapTx accesses
Jeff Garzik [Fri, 13 Apr 2012 21:34:22 +0000]
CTxMemPool: encapsulate AcceptToMemoryPool
Jeff Garzik [Fri, 13 Apr 2012 20:28:07 +0000]
CTxMemPool: encapsulate AddToMemoryPoolUnchecked(), RemoveFromMemoryPool(),
and nPooledTx
Jeff Garzik [Fri, 13 Apr 2012 20:03:09 +0000]
New class CTxMemPool, encapsulating TX memory pool data members
Jeff Garzik [Sun, 15 Apr 2012 18:39:15 +0000]
Merge pull request #1104 from laanwj/2012_04_clang
Enable and fix most compilation warnings
Jeff Garzik [Sun, 15 Apr 2012 16:25:29 +0000]
Merge pull request #1084 from dooglus/validate_secret
importprivkey doesn't check that it is given a private key
Wladimir J. van der Laan [Sun, 15 Apr 2012 16:22:26 +0000]
Merge pull request #1097 from laanwj/2012_04_runawayexception
Show a message box when runaway exception happens
Jeff Garzik [Sun, 15 Apr 2012 15:31:22 +0000]
Merge pull request #1100 from luke-jr/qrcode_errchk
Bugfix: Check that QRcode_encodeString didn't return NULL (error)
Wladimir J. van der Laan [Sun, 15 Apr 2012 11:27:00 +0000]
fix warnings: suggest explicit braces to avoid ambiguous 'else' [-Wparentheses]
Wladimir J. van der Laan [Sun, 15 Apr 2012 11:03:28 +0000]
fix warnings: '&&' within '||' [-Wlogical-op-parentheses]
Wladimir J. van der Laan [Sun, 15 Apr 2012 10:59:20 +0000]
fix warnings: delete called on 'XX' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
Wladimir J. van der Laan [Sun, 15 Apr 2012 10:53:14 +0000]
fix warnings: unused variable 'XX' [-Wunused-variable]
Wladimir J. van der Laan [Sun, 15 Apr 2012 10:42:52 +0000]
fix warnings: enumeration values 'XX' not handled in switch [-Wswitch-enum]
Wladimir J. van der Laan [Sun, 15 Apr 2012 10:31:56 +0000]
fix warnings: 'XX' defined as a struct here but previously declared as a class [-Wmismatched-tags]
Wladimir J. van der Laan [Sun, 15 Apr 2012 10:22:30 +0000]
fix warnings: array subscript is of type 'char' [-Wchar-subscripts]
Wladimir J. van der Laan [Sun, 15 Apr 2012 09:42:40 +0000]
work around issue in boost::program_options that prevents from compiling in clang
Wladimir J. van der Laan [Sun, 15 Apr 2012 10:24:03 +0000]
enable all warnings except invalid-offsetof, sign-compare, unused-parameter
Luke Dashjr [Sun, 15 Apr 2012 01:00:27 +0000]
Bugfix: Check that QRcode_encodeString didn't return NULL (error)
Without this, any error will segfault Bitcoin-Qt
Wladimir J. van der Laan [Sat, 14 Apr 2012 07:41:05 +0000]
Show a message box when runaway exception happens
This is more clear to users than when the program simply disappears (usually during initialization). It still logs the message to the console and debug log as well.
Wladimir J. van der Laan [Sat, 14 Apr 2012 16:32:30 +0000]
Rename make_windows_icon.py to .sh as it is a shell script (fixes #1099)
Jeff Garzik [Sat, 14 Apr 2012 15:50:43 +0000]
Merge pull request #1093 from jgarzik/tx-opt
Database micro-optimization for "tx" network message
Wladimir J. van der Laan [Sat, 14 Apr 2012 06:47:50 +0000]
Merge pull request #1089 from laanwj/2012_04_translationupdate
Update translations for bitcoin core
Wladimir J. van der Laan [Fri, 13 Apr 2012 06:45:26 +0000]
Update translations for bitcoin core
- Move scripts/qt to share/qt, to clean up toplevel directories
- Update english ts file which is used to source messages for Transifex
- In extract_strings_qt.py use a glob *.h *.cpp, this is safe now that the Wx UI files are removed
Wladimir J. van der Laan [Sat, 14 Apr 2012 06:27:23 +0000]
Merge pull request #1096 from laanwj/2012_04_tick
Do not show green tick unless all known blocks are downloaded (fixes #921)
Wladimir J. van der Laan [Sat, 14 Apr 2012 06:21:22 +0000]
Do not show green tick unless all known blocks are downloaded (fixes #921)
Jeff Garzik [Fri, 13 Apr 2012 22:24:55 +0000]
Locking fix for AlreadyHave()
Access to mapTransactions[] must be guarded by cs_mapTransactions lock.
Also, reformat long lines to make the switch statement more readable.
Jeff Garzik [Fri, 13 Apr 2012 21:48:15 +0000]
Database micro-optimization for "tx" network message
Open database once per "tx" message, rather than multiple times,
in the case of orphan transaction presence.
As a side effect, a now-unused CTransaction::AcceptToMemoryPool()
variant is removed.
Wladimir J. van der Laan [Fri, 13 Apr 2012 19:08:46 +0000]
Set label when selecting an address that already has a label. Fixes #1080.
Philip Kaufmann [Fri, 13 Apr 2012 16:25:56 +0000]
revert to default OS theme for progressbar / fix small glitches in bitcoingui.cpp
Wladimir J. van der Laan [Fri, 13 Apr 2012 07:16:46 +0000]
Add missing tooltip and key shortcut in settings dialog (#1088 without line break part)
Gavin Andresen [Fri, 13 Apr 2012 01:22:15 +0000]
Merge pull request #1087 from sipa/fix_1086
Fix #1086: add /testnet to passed datadir
Pieter Wuille [Fri, 13 Apr 2012 01:11:14 +0000]
Fix #1086: add /testnet to passed datadir
Jeff Garzik [Fri, 13 Apr 2012 00:07:49 +0000]
Replace several network protocol version numbers with named constants
stored in version.h.
Also, a minor CAddress code reformat while we're in there, fixing
some incorrect indentation.
Chris Moore [Thu, 12 Apr 2012 20:13:08 +0000]
CBitcoinSecret::SetString() now calls IsValid() to make sure it was passed something with the correct version.
Gavin Andresen [Thu, 12 Apr 2012 19:20:51 +0000]
Merge pull request #1041 from gavinandresen/listtransactionsfix
Bug fix listtransactions from/count handling.
Wladimir J. van der Laan [Thu, 12 Apr 2012 18:50:18 +0000]
make text in about box selectable (fixes #1055)
Wladimir J. van der Laan [Thu, 12 Apr 2012 18:38:36 +0000]
Merge pull request #1078 from Diapolo/QR-Code
QR-Code code update
Fixes problems reported on forum: https://bitcointalk.org/index.php?topic=73695.msg839804#msg839804
Philip Kaufmann [Thu, 12 Apr 2012 18:21:02 +0000]
enable wordWrap on lblQRCode / small code comment change
Philip Kaufmann [Thu, 12 Apr 2012 16:39:22 +0000]
limit length of generated URI to 255 chars to prevent a DoS against the QR-Code dialog
Philip Kaufmann [Wed, 11 Apr 2012 21:05:22 +0000]
updated to reflect pull-request suggestions / renamed some GUI elements
Philip Kaufmann [Wed, 11 Apr 2012 12:21:15 +0000]
fixed amount part of URI in QR-Codes / removed (no label) string if we have NO label / coding style updates / removed an unused variable
Jeff Garzik [Thu, 12 Apr 2012 17:24:00 +0000]
Remove obsolete Win32 AffinityBugWorkaround()
Reference miner exists for testnet-in-a-box type situations, and as a
reference. We don't care enough about highly optimized internal
mining to keep workarounds like this.
Jeff Garzik [Thu, 12 Apr 2012 16:23:58 +0000]
version.h: separate client, net sections. Move more constants to this file.
* move PROTOCOL_VERSION to version.h
* move CLIENT_VERSION* to version.h, make available past cpp stage
* clearly separate client, network version portions of version.h
Jeff Garzik [Wed, 11 Apr 2012 16:38:03 +0000]
BIP 0031: pong message
Add a pong message that is sent in reply to a ping. It echoes back a nonce
field that is now added to the ping message. Send a nonce of zero in ping
messages.
Original author: Mike Hearn @ Google
Modified Mike's change to introduce a mild form of protocol documentation in
version.h.
Gavin Andresen [Thu, 12 Apr 2012 15:14:46 +0000]
Fix OSX build errors.
Wladimir J. van der Laan [Thu, 12 Apr 2012 06:02:18 +0000]
Merge pull request #855 from sje397/ToggleHide
Toggle UI hide
Pieter Wuille [Wed, 11 Apr 2012 22:02:24 +0000]
Merge pull request #1072 from sipa/boostpaths
Use filesystem::path instead of manual string tinkering
Pieter Wuille [Mon, 9 Apr 2012 21:50:56 +0000]
Use filesystem::path instead of manual string tinkering
Where possible, use boost::filesystem::path instead of std::string or
char* for filenames. This avoids a lot of manual string tinkering, in
favor of path::operator/.
GetDataDir is also reworked significantly, it now only keeps two cached
directory names (the network-specific data dir, and the root data dir),
which are decided through a parameter instead of pre-initialized global
variables.
Finally, remove the "upgrade from 0.1.5" case where a debug.log in the
current directory has to be removed.
Wladimir J. van der Laan [Wed, 11 Apr 2012 18:06:26 +0000]
Merge pull request #1083 from laanwj/2012_04_connectionicon
Make 4th bar of connection icon green
Gavin Andresen [Wed, 11 Apr 2012 18:00:48 +0000]
Remove path.make_preferred() calls, and fix compiler error in bitcoinrpc RE: boost::system
Wladimir J. van der Laan [Wed, 11 Apr 2012 17:59:15 +0000]
by popular request, make 4th bar of connection icon green
Gavin Andresen [Wed, 11 Apr 2012 17:35:44 +0000]
Merge pull request #1077 from sipa/buildinfo
Fix build.h dependencies
Pieter Wuille [Wed, 11 Apr 2012 01:51:08 +0000]
Fix build.h dependencies
For Qt builds, the build.h file is moved to build/build.h. For regular
builds, it is moved to obj/build.h. This allows the Qt build to be done
in a different directory than the source, and without interfering with
other builds.
Pieter Wuille [Wed, 11 Apr 2012 00:21:29 +0000]
Force regeneration of build.h in qmake builds
Pieter Wuille [Tue, 10 Apr 2012 20:31:12 +0000]
Merge pull request #1054 from sipa/buildinfo
Build identification strings
Wladimir J. van der Laan [Tue, 10 Apr 2012 20:14:47 +0000]
Merge pull request #1046 from laanwj/2012_04_rpcporterror
Show error message instead of exception crash when unable to bind RPC port
Pieter Wuille [Sat, 7 Apr 2012 00:06:53 +0000]
Build identification strings
All client version information is moved to version.cpp, which optionally
(-DHAVE_BUILD_INFO) includes build.h. build.h is automatically generated
on supporting platforms via contrib/genbuild.sh, using git describe.
The git export-subst attribute is used to put the commit id statically
in version.cpp inside generated archives, and this value is used if no
build.h is present.
The gitian descriptors are modified to use git archive instead of a
copy, to create the src/ directory in the output. This way,
src/src/version.cpp will contain the static commit id. To prevent
gitian builds from getting the "-dirty" marker in their git-describe
generated identifiers, no touching of files or running sed on the
makefile is performed anymore. This does not seem to influence
determinism.
sje397 [Fri, 17 Feb 2012 14:34:53 +0000]
Toggle main window hide on tray icon click
- converted openBictoinAction to toggleHideAction
- put GUIUtil functions into a namespace instead of a class
- put window-related functions together in optionsdialog
Reasoning:
- toggle is more typical behaviour
- it's more functional
- better UX
The typical issue with toggling visibility is that when a window
is obscured by other windows but in the 'shown' state, hiding it
isn't what you want. I've added an 'isObscured' function to GUIUtil
that checks several pixels in the window to see if they are visible
on the desktop so that an obscured but shown window can be raised.
Conflicts:
src/qt/guiutil.cpp
src/qt/guiutil.h
Pieter Wuille [Tue, 10 Apr 2012 10:41:09 +0000]
Merge pull request #1070 from cardpuncher/patch-1
Trivial: added comment lines in French & Turkish
Pieter Wuille [Mon, 9 Apr 2012 20:25:17 +0000]
Merge pull request #1052 from sipa/scopedlocks
Use scoped locks instead of CRITICAL_BLOCK
cardpuncher [Mon, 9 Apr 2012 19:22:38 +0000]
Added comment lines in French & Turkish which basically mean "Bitcoin, virtual P2P cryptocurrency".
Gavin Andresen [Mon, 9 Apr 2012 14:41:59 +0000]
Merge branch 'filesystem' of https://github.com/Diapolo/bitcoin