novacoin.git
11 years agoMerge branch '0.5.x' into 0.6.0.x
Luke Dashjr [Thu, 14 Jun 2012 18:13:46 +0000]
Merge branch '0.5.x' into 0.6.0.x

Conflicts:
src/main.h
src/net.cpp
src/serialize.h

11 years agoMerge branch '0.4.x' into 0.5.x
Luke Dashjr [Thu, 14 Jun 2012 18:07:11 +0000]
Merge branch '0.4.x' into 0.5.x

Conflicts:
doc/release-process.txt
src/serialize.h

11 years agoFix build of testcases after commit 0f10b21719e1b0d9683a142f0a7105e65f095694
Wladimir J. van der Laan [Thu, 14 Jun 2012 07:41:11 +0000]
Fix build of testcases after commit 0f10b21719e1b0d9683a142f0a7105e65f095694

11 years agoBugfix: Fix various places where Bitcoin-Qt was being shutdown improperly
Philip Kaufmann [Mon, 11 Jun 2012 05:40:14 +0000]
Bugfix: Fix various places where Bitcoin-Qt was being shutdown improperly

(Partial/merge of upstream 9247134eaba9a1d0fa74f22de238af14766630051a3f0da9229a8e524d1010cdc8bd3b9da71fe529, and 3e343522226e6c249f5cb05436eec347b87c6361)

11 years agoDon't call exit() in Shutdown() for Bitcoin-Qt (fixes a tray-icon issue)
Philip Kaufmann [Mon, 11 Jun 2012 05:40:14 +0000]
Don't call exit() in Shutdown() for Bitcoin-Qt (fixes a tray-icon issue)

(partial of 9247134eaba9a1d0fa74f22de238af1476663005)

11 years agoUpdate wiki changelog at doc/release-process.txt
Matt Corallo [Tue, 12 Jun 2012 23:06:40 +0000]
Update wiki changelog at doc/release-process.txt

11 years agochange initial Balance on overviewpage from "123.456 BTC" to "0 BTC" to not confuse...
Philip Kaufmann [Mon, 11 Jun 2012 20:40:06 +0000]
change initial Balance on overviewpage from "123.456 BTC" to "0 BTC" to not confuse users, which could see it before we init with the real wallet balance

11 years agoremoved ability to translate "0 BTC" and "123.456 BTC" as this is only used as previe...
Philip Kaufmann [Sun, 6 May 2012 14:57:12 +0000]
removed ability to translate "0 BTC" and "123.456 BTC" as this is only used as preview in the Qt Designer anyway

(partial of 4295311da34ed8132351855f057decedfe434b44)

11 years agoFix broken config files
Matt Corallo [Mon, 11 Jun 2012 23:52:34 +0000]
Fix broken config files

11 years agoDo not select first address automatically in the address book
Wladimir J. van der Laan [Tue, 12 Jun 2012 08:46:24 +0000]
Do not select first address automatically in the address book

This contributed to an accidental send (#1384), and has no clear advantage, better to disable it.

11 years agoBump VERSION so we can differentiate between fixed 0.4.7rc2 and not-fixed 0.4.7rc1
Luke Dashjr [Thu, 14 Jun 2012 15:59:18 +0000]
Bump VERSION so we can differentiate between fixed 0.4.7rc2 and not-fixed 0.4.7rc1

11 years agoBugfix: Move IsStandard scriptSig size check out of IsPushOnly, since BIP16 verificat...
Luke Dashjr [Tue, 12 Jun 2012 23:50:38 +0000]
Bugfix: Move IsStandard scriptSig size check out of IsPushOnly, since BIP16 verification uses the latter too

This caused clients to reject block #177618 since it has a P2SH transaction with over 200 bytes in scriptSig.

(Upstream commit: e679ec969c8b22c676ebb10bea1038f6c8f13b33)

11 years agoBugfix: Allow tray icon to linger until Bitcoin-Qt shuts down completely. Fixes #908
Luke Dashjr [Wed, 6 Jun 2012 20:00:22 +0000]
Bugfix: Allow tray icon to linger until Bitcoin-Qt shuts down completely. Fixes #908

Upstream commit: 7cfbe1fee465e82ddbdc8ed17dfcce791bd765f5

11 years agofix an incorrect if-clause in net.cpp
Philip Kaufmann [Tue, 8 May 2012 21:02:48 +0000]
fix an incorrect if-clause in net.cpp

11 years agoSerialize access to debug.log stream
Michael Hendricks [Fri, 2 Mar 2012 19:24:38 +0000]
Serialize access to debug.log stream

Acquire an exclusive, advisory lock before sending output to debug.log
and release it when we're done. This should avoid output from multiple
threads being interspersed in the log file.

We can't use CRITICAL_SECTION machinery for this because the debug log
is written during startup and shutdown when that machinery is not
available.

(Thanks to Gavin for pointing out the CRITICAL_SECTION problems based
on his earlier work in this area)

11 years agoCorrect blockchain size in contrib/debian.
Matt Corallo [Sat, 2 Jun 2012 14:33:46 +0000]
Correct blockchain size in contrib/debian.

* Updates package description to note that blockchain now takes
  2+ GB instead of 150+ MB.

(PARTIAL of 8f6111bb9cd598954e9634d9fe4500fcf5ae83de)

11 years ago"USE_UPNP=-" is needed to remove UPnP support.
Chris Moore [Sun, 3 Jun 2012 23:11:11 +0000]
"USE_UPNP=-" is needed to remove UPnP support.

11 years ago.gitignore: add test_bitcoin
Jeff Garzik [Thu, 24 May 2012 01:45:26 +0000]
.gitignore: add test_bitcoin

11 years agoMerge branch '0.5.x' into 0.6.0.x
Luke Dashjr [Tue, 22 May 2012 22:57:10 +0000]
Merge branch '0.5.x' into 0.6.0.x

Conflicts:
src/main.cpp

11 years agoMerge branch '0.4.x' into 0.5.x
Luke Dashjr [Tue, 22 May 2012 22:55:49 +0000]
Merge branch '0.4.x' into 0.5.x

Conflicts:
src/ui.cpp
src/ui.h
src/uibase.cpp
src/xpm/about.xpm

11 years agoPrevent crashes due to missing or corrupted blk????.dat records
Jeff Garzik [Tue, 22 May 2012 19:23:17 +0000]
Prevent crashes due to missing or corrupted blk????.dat records

11 years agoPrevent crashes due to missing or corrupted database records
Jeff Garzik [Tue, 22 May 2012 19:12:52 +0000]
Prevent crashes due to missing or corrupted database records

Any problems seen during deserialization will throw an uncaught
exception, crashing the entire bitcoin process.  Properly return an
error instead, so that we may at least log the error and gracefully
shutdown other portions of the app.

11 years agoCorrect debug.log output to show correct function the debug is coming from.
R E Broadley [Tue, 22 May 2012 11:06:08 +0000]
Correct debug.log output to show correct function the debug is coming from.

11 years agoFilter out whitespace and zero-width non-breaking spaces in validator
Wladimir J. van der Laan [Thu, 17 May 2012 10:10:15 +0000]
Filter out whitespace and zero-width non-breaking spaces in validator

- Fixes issues with copy/pasting from web or html emails (#1325)

11 years agoUpdate License in File Headers
Fordy [Fri, 18 May 2012 14:02:28 +0000]
Update License in File Headers

I originally created a pull to replace the "COPYING" in crypter.cpp and
crypter.h, but it turned out that COPYING was actually the correct
file.

11 years agoUpdate License in File Headers
Fordy [Fri, 18 May 2012 14:02:28 +0000]
Update License in File Headers

I originally created a pull to replace the "COPYING" in crypter.cpp and
crypter.h, but it turned out that COPYING was actually the correct
file.

11 years agoUpdate License in File Headers
Fordy [Fri, 18 May 2012 14:02:28 +0000]
Update License in File Headers

I originally created a pull to replace the "COPYING" in crypter.cpp and
crypter.h, but it turned out that COPYING was actually the correct
file.

11 years agoremove 2 ugly spaces from a message string
Philip Kaufmann [Mon, 14 May 2012 05:49:17 +0000]
remove 2 ugly spaces from a message string

(PARTIAL of 966ae00)

11 years agoAdd build directory to .gitignore, so that it's not tracked.
R E Broadley [Thu, 17 May 2012 18:09:21 +0000]
Add build directory to .gitignore, so that it's not tracked.

11 years agoFix typo. libarcode => libqrcode
Christian von Roques [Thu, 17 May 2012 15:33:59 +0000]
Fix typo.  libarcode => libqrcode

11 years agoAlways check return values of TxnBegin() and TxnCommit()
Jeff Garzik [Mon, 14 May 2012 05:11:11 +0000]
Always check return values of TxnBegin() and TxnCommit()

11 years agoAlways check return values of TxnBegin() and TxnCommit()
Jeff Garzik [Mon, 14 May 2012 05:11:11 +0000]
Always check return values of TxnBegin() and TxnCommit()

PARTIAL, since d68dcf7 isn't backported (yet)

11 years agoHopefully final fix for the stuck blockchain issue
Pieter Wuille [Mon, 7 May 2012 19:36:30 +0000]
Hopefully final fix for the stuck blockchain issue

Immediately issue a "getblocks", instead of a "getdata" (which will
trigger the relevant "inv" to be sent anyway), and only do so when
the previous set of invs led us into a known and attached part of
the block tree.

11 years agoremove string "TextLabel" from warningLabel, as this is unneeded and as such is a...
Philip Kaufmann [Sat, 12 May 2012 22:16:50 +0000]
remove string "TextLabel" from warningLabel, as this is unneeded and as such is a silly translation less to do :)

11 years agoProperly escape " in strings when exporting CSV
Wladimir J. van der Laan [Fri, 11 May 2012 18:17:09 +0000]
Properly escape " in strings when exporting CSV

11 years agoCorrect Date
Fordy [Sat, 12 May 2012 03:36:37 +0000]
Correct Date

11 years agoCorrect Date
Fordy [Sat, 12 May 2012 03:32:03 +0000]
Correct Date

11 years agoremove 2 ugly spaces from a string used in translations
Philip Kaufmann [Tue, 8 May 2012 07:31:25 +0000]
remove 2 ugly spaces from a string used in translations

11 years agoBitcoin-Qt: Remove redundant tooltip on optional transaction fee. Fixes #1218
Luke Dashjr [Mon, 7 May 2012 19:22:09 +0000]
Bitcoin-Qt: Remove redundant tooltip on optional transaction fee. Fixes #1218

11 years agoBump version to 0.6.0.8
Luke Dashjr [Tue, 8 May 2012 20:11:44 +0000]
Bump version to 0.6.0.8

11 years agoMerge branch '0.5.x' into 0.6.0.x
Luke Dashjr [Tue, 8 May 2012 20:10:20 +0000]
Merge branch '0.5.x' into 0.6.0.x

Conflicts:
bitcoin-qt.pro
doc/README
doc/README_windows.txt
share/setup.nsi
src/serialize.h

11 years agoBump version to 0.5.6
Luke Dashjr [Tue, 8 May 2012 20:09:43 +0000]
Bump version to 0.5.6

11 years agoMerge branch '0.4.x' into 0.5.x
Luke Dashjr [Tue, 8 May 2012 20:08:19 +0000]
Merge branch '0.4.x' into 0.5.x

Conflicts:
contrib/Bitcoin.app/Contents/Info.plist
doc/README
doc/README_windows.txt
share/setup.nsi
src/serialize.h

11 years agoBump version to 0.4.7
Luke Dashjr [Tue, 8 May 2012 19:53:29 +0000]
Bump version to 0.4.7

12 years agoUpdate/fix translations
Luke Dashjr [Mon, 7 May 2012 05:34:18 +0000]
Update/fix translations

12 years agoMerge branch '0.5.x' into 0.6.0.x
Luke Dashjr [Mon, 7 May 2012 04:10:54 +0000]
Merge branch '0.5.x' into 0.6.0.x

Conflicts:
src/main.cpp
src/qt/locale/bitcoin_da.ts
src/qt/locale/bitcoin_de.ts
src/qt/locale/bitcoin_en.ts
src/qt/locale/bitcoin_es.ts
src/qt/locale/bitcoin_es_CL.ts
src/qt/locale/bitcoin_hu.ts
src/qt/locale/bitcoin_it.ts
src/qt/locale/bitcoin_nb.ts
src/qt/locale/bitcoin_nl.ts
src/qt/locale/bitcoin_pt_BR.ts
src/qt/locale/bitcoin_ru.ts
src/qt/locale/bitcoin_uk.ts
src/qt/locale/bitcoin_zh_CN.ts
src/qt/locale/bitcoin_zh_TW.ts

12 years agoUpdate/fix translations
Luke Dashjr [Mon, 7 May 2012 03:57:39 +0000]
Update/fix translations

12 years agoPrevent stuck download: correct solution
Pieter Wuille [Sat, 5 May 2012 02:04:38 +0000]
Prevent stuck download: correct solution

Pull request #948 introduced a fix for nodes stuck on a long side branch
of the main chain. The fix was non-functional however, as the additional
getdata request was created in a first step of processing, but dropped
in a second step as it was considered redundant. This commits fixes it
by sending the request directly.

12 years agoMerge commit '293f264' into 0.6.0.x
Luke Dashjr [Mon, 7 May 2012 04:00:26 +0000]
Merge commit '293f264' into 0.6.0.x

12 years agoMerge branch '0.4.x' into 0.5.x
Luke Dashjr [Mon, 7 May 2012 02:46:14 +0000]
Merge branch '0.4.x' into 0.5.x

12 years agoPrevent stuck download: correct solution
Pieter Wuille [Sat, 5 May 2012 02:04:38 +0000]
Prevent stuck download: correct solution

Pull request #948 introduced a fix for nodes stuck on a long side branch
of the main chain. The fix was non-functional however, as the additional
getdata request was created in a first step of processing, but dropped
in a second step as it was considered redundant. This commits fixes it
by sending the request directly.

12 years agoPrevent stuck block download in large reorganisations
Pieter Wuille [Sun, 18 Mar 2012 22:47:26 +0000]
Prevent stuck block download in large reorganisations

In cases of very large reorganisations (hundreds of blocks), a situation
may appear where an 'inv' is sent as response to a 'getblocks', but the
last block mentioned in the inv is already known to the receiver node.
However, the supplying node uses a request for this last block as a
trigger to send the rest of the inv blocks. If it never comes, the block
chain download is stuck.

This commit makes the receiver node always request the last inv'ed block,
even if it is already known, to prevent this problem.

12 years agofix #952 by checking if we have a new address or an updated label
Philip Kaufmann [Thu, 3 May 2012 12:52:15 +0000]
fix #952 by checking if we have a new address or an updated label

12 years agoHide UI immediately after leaving the main loop.
Wladimir J. van der Laan [Sun, 6 May 2012 06:14:19 +0000]
Hide UI immediately after leaving the main loop.

Prevents it from seeming to hang during shutdown if shutdown is triggered while the window is open.

12 years agoMerge branch '0.5.x' into 0.6.0.x
Luke Dashjr [Sun, 6 May 2012 05:35:58 +0000]
Merge branch '0.5.x' into 0.6.0.x

12 years agoMerge branch '0.4.x' into 0.5.x
Luke Dashjr [Sun, 6 May 2012 05:35:50 +0000]
Merge branch '0.4.x' into 0.5.x

12 years agoBugfix: store source address in addrman
Pieter Wuille [Sat, 5 May 2012 19:27:52 +0000]
Bugfix: store source address in addrman

12 years agoFix addrman crashes
Pieter Wuille [Sat, 5 May 2012 19:22:55 +0000]
Fix addrman crashes

A function returned the element to remove from a bucket, instead of its
position in that bucket. This function was only called when a tried
bucket overflowed, which only happens after many outgoing connections
have been made.

Closes: #1065, #1156

12 years agoFixed non-sensical error message
Peter Todd [Sat, 28 Apr 2012 20:29:27 +0000]
Fixed non-sensical error message

Previously trying to create a multisig address that required less than
one signature would output something like the following:

"wrong number of keys(got 1, need at least 0)"

12 years agoBugfix: %-12I64d is not valid and causes the parameter to be skipped, use %12"PRI64d...
Luke Dashjr [Sun, 6 May 2012 05:27:08 +0000]
Bugfix: %-12I64d is not valid and causes the parameter to be skipped, use %12"PRI64d" instead

Conflicts:

src/walletdb.cpp

12 years agoremove HTML code around "Wallet" (displayed on overview page) and use Qt tags for...
Philip Kaufmann [Wed, 4 Apr 2012 07:07:55 +0000]
remove HTML code around "Wallet" (displayed on overview page) and use Qt tags for font settings

12 years agoMerge branch '0.5.x' into 0.6.0.x
Luke Dashjr [Fri, 4 May 2012 19:55:54 +0000]
Merge branch '0.5.x' into 0.6.0.x

Conflicts:
src/main.cpp

12 years agoBugfix: Remove redundant duplicate transaction check
Luke Dashjr [Fri, 4 May 2012 19:54:24 +0000]
Bugfix: Remove redundant duplicate transaction check

12 years agoMerge branch '0.6.0.x' of gitorious.org:+bitcoin-stable-developers/bitcoin/bitcoind...
Luke Dashjr [Fri, 4 May 2012 18:58:37 +0000]
Merge branch '0.6.0.x' of gitorious.org:+bitcoin-stable-developers/bitcoin/bitcoind-stable into 0.6.0.x

12 years agoMerge branch '0.5.x' into 0.6.0.x
Luke Dashjr [Fri, 4 May 2012 18:57:03 +0000]
Merge branch '0.5.x' into 0.6.0.x

Conflicts:
src/main.cpp
src/serialize.h

12 years agoMerge branch '0.4.x' into 0.5.x
Luke Dashjr [Fri, 4 May 2012 18:55:15 +0000]
Merge branch '0.4.x' into 0.5.x

12 years agoCheck earlier for blocks with duplicate transactions. Fixes #1167
Gavin Andresen [Mon, 30 Apr 2012 00:56:55 +0000]
Check earlier for blocks with duplicate transactions. Fixes #1167

12 years agoCheck earlier for blocks with duplicate transactions. Fixes #1167
Gavin Andresen [Mon, 30 Apr 2012 00:56:55 +0000]
Check earlier for blocks with duplicate transactions. Fixes #1167

12 years agoremove obsolete BackupWallet() entry in wallet.h
Philip Kaufmann [Thu, 3 May 2012 09:30:52 +0000]
remove obsolete BackupWallet() entry in wallet.h

12 years agoadd bitcoin-qt.rc to OTHER_FILES (shown in Qt Creator)
Philip Kaufmann [Tue, 1 May 2012 20:26:33 +0000]
add bitcoin-qt.rc to OTHER_FILES (shown in Qt Creator)

12 years agofix compiler warning "suggest parentheses around assignment used as truth
Philip Kaufmann [Mon, 30 Apr 2012 23:46:03 +0000]
fix compiler warning "suggest parentheses around assignment used as truth
value [-Wparentheses]" in util.cpp

12 years agofix DEPENDPATH in the project file, as json has no include sub-dir and src was in...
Philip Kaufmann [Tue, 1 May 2012 16:45:10 +0000]
fix DEPENDPATH in the project file, as json has no include sub-dir and src was in twice

12 years agoremove unused typedef in serialize.h
Philip Kaufmann [Mon, 30 Apr 2012 23:56:47 +0000]
remove unused typedef in serialize.h

12 years agochange button tooltip on sign message page for copy to clipboard as it was missleading
Philip Kaufmann [Sun, 22 Apr 2012 15:32:08 +0000]
change button tooltip on sign message page for copy to clipboard as it was missleading

12 years agoMerge branch '0.5.x' into 0.6.0.x
Luke Dashjr [Fri, 27 Apr 2012 20:28:00 +0000]
Merge branch '0.5.x' into 0.6.0.x

12 years agofix compiler error in bitcoinrpc RE: boost::system
Gavin Andresen [Wed, 11 Apr 2012 18:00:48 +0000]
fix compiler error in bitcoinrpc RE: boost::system

(Partial of 2232717cba9e9f06a01e8f37bcea4e79ee65205f)

12 years agoBump win32.deps version number for new openssl
Gavin Andresen [Fri, 27 Apr 2012 15:53:11 +0000]
Bump win32.deps version number for new openssl

12 years agoMerge branch '0.5.x' into 0.6.0.x
Luke Dashjr [Fri, 27 Apr 2012 17:57:43 +0000]
Merge branch '0.5.x' into 0.6.0.x

Conflicts:
contrib/gitian-descriptors/gitian-win32.yml

12 years agoWindows build: compile against openssl 1.0.1b
Gavin Andresen [Fri, 27 Apr 2012 14:52:14 +0000]
Windows build: compile against openssl 1.0.1b

12 years agoMerge branch '0.4.x' into 0.5.x
Luke Dashjr [Fri, 27 Apr 2012 17:52:02 +0000]
Merge branch '0.4.x' into 0.5.x

Conflicts:
doc/build-msw.txt
src/makefile.linux-mingw
src/makefile.mingw

12 years agoWindows build: compile against openssl 1.0.1b
Gavin Andresen [Fri, 27 Apr 2012 14:52:14 +0000]
Windows build: compile against openssl 1.0.1b

12 years agoWindows build: compile against openssl 1.0.1b
Gavin Andresen [Fri, 27 Apr 2012 14:52:14 +0000]
Windows build: compile against openssl 1.0.1b

12 years agoMerge branch '0.5.x' into 0.6.0.x
Luke Dashjr [Fri, 27 Apr 2012 14:57:15 +0000]
Merge branch '0.5.x' into 0.6.0.x

Conflicts:
bitcoin-qt.pro
doc/README
doc/README_windows.txt
share/setup.nsi
src/serialize.h

12 years agoBump version to 0.5.5
Luke Dashjr [Fri, 27 Apr 2012 14:55:06 +0000]
Bump version to 0.5.5

12 years agoMerge branch '0.4.x' into 0.5.x
Luke Dashjr [Fri, 27 Apr 2012 14:53:14 +0000]
Merge branch '0.4.x' into 0.5.x

Conflicts:
contrib/Bitcoin.app/Contents/Info.plist
doc/README
doc/README_windows.txt
share/setup.nsi
src/protocol.h
src/serialize.h

12 years agoBump version to 0.4.6
Luke Dashjr [Fri, 27 Apr 2012 14:50:24 +0000]
Bump version to 0.4.6

12 years agolistsinceblock: rpc param blockid -> blockhash
freewil [Thu, 26 Apr 2012 16:48:33 +0000]
listsinceblock: rpc param blockid -> blockhash

This is more consistent with the rest of the labeling seen
by the user when accessing the rpc commands.

12 years agoremove strange debug message from listsinceblock
freewil [Thu, 26 Apr 2012 17:12:44 +0000]
remove strange debug message from listsinceblock

12 years agoWe should include netinet/in.h to use sockaddr_in (POSIX.1-2001)
Timothy Redaelli [Wed, 25 Apr 2012 12:07:24 +0000]
We should include netinet/in.h to use sockaddr_in (POSIX.1-2001)

12 years agoWe should include netinet/in.h to use sockaddr_in (POSIX.1-2001)
Timothy Redaelli [Wed, 25 Apr 2012 12:07:24 +0000]
We should include netinet/in.h to use sockaddr_in (POSIX.1-2001)

12 years agoWe should include netinet/in.h to use sockaddr_in (POSIX.1-2001)
Timothy Redaelli [Wed, 25 Apr 2012 12:07:24 +0000]
We should include netinet/in.h to use sockaddr_in (POSIX.1-2001)

12 years agoCBlock::WriteToDisk() properly checks ftell(3) for error return
Jeff Garzik [Sun, 22 Apr 2012 17:59:24 +0000]
CBlock::WriteToDisk() properly checks ftell(3) for error return

Rather than storing ftell(3)'s return value -- a long -- in an
unsigned int, we store and check a properly typed temp.  Then, assured a
non-negative value, we store in nBlockPosRet.

12 years agoTest ScriptSigArgsExpected() for error, before accumulating return value
Jeff Garzik [Sun, 22 Apr 2012 17:44:12 +0000]
Test ScriptSigArgsExpected() for error, before accumulating return value

12 years agoMerge branch '0.5.x' into 0.6.0.x
Luke Dashjr [Sun, 22 Apr 2012 14:07:24 +0000]
Merge branch '0.5.x' into 0.6.0.x

Conflicts:
src/main.h
src/net.cpp
src/util.cpp

12 years agoMerge branch '0.4.x' into 0.5.x
Luke Dashjr [Sun, 22 Apr 2012 14:05:43 +0000]
Merge branch '0.4.x' into 0.5.x

Conflicts:
src/main.cpp

12 years agoAdd missing includes. (Fix bulding under GCC 4.7)
Timothy Redaelli [Fri, 20 Apr 2012 10:50:57 +0000]
Add missing includes. (Fix bulding under GCC 4.7)

(Note: GCC 4.7 build NOT tested with backports -Luke)

12 years agoFix bugs on 'unsigned char' platforms.
Dwayne C. Litzenberger [Mon, 16 Apr 2012 05:32:55 +0000]
Fix bugs on 'unsigned char' platforms.

In ISO C++, the signedness of 'char' is undefined.  On some platforms (e.g.
ARM), 'char' is an unsigned type, but some of the code relies on 'char' being
signed (as it is on x86).  This is indicated by compiler warnings like this:

 bignum.h: In constructor 'CBigNum::CBigNum(char)':
 bignum.h:81:59: warning: comparison is always true due to limited range of data type [-Wtype-limits]

 util.cpp: In function 'bool IsHex(const string&)':
 util.cpp:427:28: warning: comparison is always false due to limited range of data type [-Wtype-limits]

In particular, IsHex erroneously returned true regardless of the input
characters, as long as the length of the string was a positive multiple of 2.

Note: For testing, it's possible using GCC to force char to be unsigned by
adding the -funsigned-char parameter to xCXXFLAGS.

12 years agoFix bugs on 'unsigned char' platforms.
Dwayne C. Litzenberger [Mon, 16 Apr 2012 05:32:55 +0000]
Fix bugs on 'unsigned char' platforms.

In ISO C++, the signedness of 'char' is undefined.  On some platforms (e.g.
ARM), 'char' is an unsigned type, but some of the code relies on 'char' being
signed (as it is on x86).  This is indicated by compiler warnings like this:

 bignum.h: In constructor 'CBigNum::CBigNum(char)':
 bignum.h:81:59: warning: comparison is always true due to limited range of data type [-Wtype-limits]

 util.cpp: In function 'bool IsHex(const string&)':
 util.cpp:427:28: warning: comparison is always false due to limited range of data type [-Wtype-limits]

In particular, IsHex erroneously returned true regardless of the input
characters, as long as the length of the string was a positive multiple of 2.

Note: For testing, it's possible using GCC to force char to be unsigned by
adding the -funsigned-char parameter to xCXXFLAGS.

12 years agoFix phexdigits[255] is undefined.
Dwayne C. Litzenberger [Mon, 16 Apr 2012 05:31:38 +0000]
Fix phexdigits[255] is undefined.

12 years agoFix phexdigits[255] is undefined.
Dwayne C. Litzenberger [Mon, 16 Apr 2012 05:31:38 +0000]
Fix phexdigits[255] is undefined.