Jeff Garzik [Sun, 15 Apr 2012 03:55:05 +0000]
Encapsulate RPC command dispatch in an array of CRPCCommand's
Wladimir J. van der Laan [Fri, 20 Apr 2012 17:18:45 +0000]
Merge pull request #1122 from dlitz/unsigned-char-fix
Unsigned char fix & fix undefined phexdigits[255]
Timothy Redaelli [Fri, 20 Apr 2012 10:50:57 +0000]
Add missing includes. (Fix bulding under GCC 4.7)
Pieter Wuille [Thu, 19 Apr 2012 11:33:04 +0000]
Merge pull request #959 from rebroad/LoadBlockIndexKillable
Added ability to respond to signals during Block Loading stage.
R E Broadley [Wed, 18 Apr 2012 11:30:24 +0000]
Added ability to respond to signals during Block Loading stage.
Dwayne C. Litzenberger [Mon, 16 Apr 2012 05:32:55 +0000]
Fix bugs on 'unsigned char' platforms.
In ISO C++, the signedness of 'char' is undefined. On some platforms (e.g.
ARM), 'char' is an unsigned type, but some of the code relies on 'char' being
signed (as it is on x86). This is indicated by compiler warnings like this:
bignum.h: In constructor 'CBigNum::CBigNum(char)':
bignum.h:81:59: warning: comparison is always true due to limited range of data type [-Wtype-limits]
util.cpp: In function 'bool IsHex(const string&)':
util.cpp:427:28: warning: comparison is always false due to limited range of data type [-Wtype-limits]
In particular, IsHex erroneously returned true regardless of the input
characters, as long as the length of the string was a positive multiple of 2.
Note: For testing, it's possible using GCC to force char to be unsigned by
adding the -funsigned-char parameter to xCXXFLAGS.
Dwayne C. Litzenberger [Mon, 16 Apr 2012 05:31:38 +0000]
Fix phexdigits[255] is undefined.
Pieter Wuille [Tue, 17 Apr 2012 21:27:59 +0000]
Add missing breaks in optionmodel's switch case
Wladimir J. van der Laan [Tue, 17 Apr 2012 21:33:26 +0000]
Merge pull request #1118 from sipa/addbreaks
Add missing breaks in optionmodel's switch case
Pieter Wuille [Tue, 17 Apr 2012 21:27:59 +0000]
Add missing breaks in optionmodel's switch case
Pieter Wuille [Tue, 17 Apr 2012 21:23:31 +0000]
Merge pull request #1114 from sipa/lesssync
Reduce sync frequency for blkindex.dat
Pieter Wuille [Tue, 17 Apr 2012 16:50:45 +0000]
Fix potential deadlock
Conflict:
* cs_main in ProcessMessages() (before calling ProcessMessages)
* cs_vSend in CNode::BeginMessage
versus:
* cs_vSend in ThreadMessageHandler2 (before calling SendMessages)
* cs_main in SendMessages
Even though cs_vSend is a try_lock, if it succeeds simultaneously with
the locking of cs_main in ProcessMessages(), it could cause a deadlock.
Jeff Garzik [Sun, 15 Apr 2012 21:00:20 +0000]
Fix misc. minor sign-comparison warnings
Jeff Garzik [Sun, 15 Apr 2012 20:59:48 +0000]
CNode's nHeaderStart may be negative, so change its type (PARTIAL)
Jeff Garzik [Sun, 15 Apr 2012 20:58:32 +0000]
Fix sign-compare warnings: netbase's Lookup* max-solutions may be unsigned
Jeff Garzik [Sun, 15 Apr 2012 20:52:09 +0000]
Fix loop index var types, fixing many minor sign comparison warnings
foo.size() typically returns an unsigned integral type; make loop variables
match those types' signedness.
Jeff Garzik [Sun, 15 Apr 2012 20:52:09 +0000]
Fix loop index var types, fixing many minor sign comparison warnings
foo.size() typically returns an unsigned integral type; make loop variables
match those types' signedness.
Jeff Garzik [Sun, 15 Apr 2012 20:47:24 +0000]
The string class returns string::npos, when find() fails.
Noticed when sign-comparison warnings were enabled.
Wladimir J. van der Laan [Mon, 16 Apr 2012 09:46:13 +0000]
Add forgotten initializer
Jeff Garzik [Tue, 17 Apr 2012 16:30:00 +0000]
AlreadyHave(): only hold lock during mapTransactions access
Pieter Wuille [Tue, 17 Apr 2012 18:37:47 +0000]
Fix tests after recent refactors
Pieter Wuille [Tue, 17 Apr 2012 18:12:48 +0000]
Merge remote-tracking branch 'jgarzik/mempool'
Pieter Wuille [Tue, 17 Apr 2012 18:05:02 +0000]
Merge pull request #1117 from sipa/deadlockfix
Fix potential deadlock
Pieter Wuille [Tue, 17 Apr 2012 18:04:29 +0000]
Merge pull request #1112 from sipa/saneserial
Further reduce header dependencies
Pieter Wuille [Mon, 16 Apr 2012 12:56:45 +0000]
Further reduce header dependencies
This commit removes the dependency of serialize.h on PROTOCOL_VERSION,
and makes this parameter required instead of implicit. This is much saner,
as it makes the places where changing a version number can have an
influence obvious.
Jeff Garzik [Sun, 15 Apr 2012 22:20:05 +0000]
Move proto version to version.h. Reduce header deps a bit more.
Jeff Garzik [Sun, 15 Apr 2012 21:39:49 +0000]
Move CWalletDB code to new walletdb module.
In addition to standard code separation, this change opens the door
to fixing several include inter-dependencies.
Pieter Wuille [Sun, 15 Apr 2012 20:10:54 +0000]
Remove headers.h
Gavin Andresen [Tue, 17 Apr 2012 17:55:56 +0000]
Merge pull request #1106 from jgarzik/sign-compare
Fix many sign-comparison warnings found in bitcoin codebase
Jeff Garzik [Fri, 13 Apr 2012 22:24:55 +0000]
Locking fix for AlreadyHave()
Access to mapTransactions[] must be guarded by cs_mapTransactions lock.
Gavin Andresen [Tue, 17 Apr 2012 17:12:33 +0000]
Merge pull request #1115 from laanwj/2012_04_cleanupmisc
Delete unused, unreachable and commented code, add missing initializer
Pieter Wuille [Tue, 17 Apr 2012 16:50:45 +0000]
Fix potential deadlock
Conflict:
* cs_main in ProcessMessages() (before calling ProcessMessages)
* cs_vSend in CNode::BeginMessage
versus:
* cs_vSend in ThreadMessageHandler2 (before calling SendMessages)
* cs_main in SendMessages
Even though cs_vSend is a try_lock, if it succeeds simultaneously with
the locking of cs_main in ProcessMessages(), it could cause a deadlock.
Jeff Garzik [Tue, 17 Apr 2012 16:31:51 +0000]
main.cpp: replace tabs with spaces
Sometimes they sneak in through the 'vi' door
Jeff Garzik [Tue, 17 Apr 2012 16:30:00 +0000]
AlreadyHave(): only hold lock during mapTransactions access
Wladimir J. van der Laan [Mon, 16 Apr 2012 09:44:05 +0000]
Remove unused and unreachable code
Wladimir J. van der Laan [Mon, 16 Apr 2012 09:46:13 +0000]
Add forgotten initializer
Pieter Wuille [Tue, 17 Apr 2012 16:27:00 +0000]
Reduce sync frequency for blkindex.dat
Since auto-remove-db-logs was enabled, each time a CTxDB was closed
outside of the initial download window, it causes a checkpoint + log
cleanup. This is overkill, so reduce the sync frequency to once per
minute at most.
Jeff Garzik [Tue, 17 Apr 2012 16:23:49 +0000]
Merge pull request #1094 from jgarzik/already-have-locking
Locking fix for AlreadyHave()
Jeff Garzik [Tue, 17 Apr 2012 16:16:46 +0000]
Bump PROTOCOL_VERSION to 60001, thereby enabling BIP31
Jeff Garzik [Tue, 17 Apr 2012 15:51:17 +0000]
Merge pull request #1081 from jgarzik/pong
BIP 0031: pong message
Wladimir J. van der Laan [Fri, 13 Apr 2012 19:08:46 +0000]
Set label when selecting an address that already has a label. Fixes #1080.
Wladimir J. van der Laan [Mon, 16 Apr 2012 12:41:39 +0000]
Merge pull request #1092 from laanwj/2012_04_sendcoins_setlabelfix
When sending coins, set label when selecting address that already has a label
Wladimir J. van der Laan [Mon, 16 Apr 2012 07:55:37 +0000]
Merge pull request #1091 from Diapolo/GUI-BlockDL
revert to default OS theme for progressbar (fix #1071)
Luke Dashjr [Mon, 16 Apr 2012 01:15:48 +0000]
Merge branch '0.5.x' into 0.6.0.x
Conflicts:
src/qt/bitcoin.cpp
src/qt/bitcoingui.cpp
src/qt/guiutil.cpp
src/qt/guiutil.h
src/qt/sendcoinsdialog.cpp
src/qt/sendcoinsdialog.h
src/util.cpp
Luke Dashjr [Mon, 16 Apr 2012 01:06:10 +0000]
Merge branch '0.5.0.x' into 0.5.x
Luke Dashjr [Mon, 16 Apr 2012 01:05:54 +0000]
Merge branch '0.4.x' into 0.5.0.x
Conflicts:
src/keystore.h
Wladimir J. van der Laan [Sun, 15 Apr 2012 11:27:00 +0000]
fix warnings: suggest explicit braces to avoid ambiguous 'else' [-Wparentheses]
Wladimir J. van der Laan [Sun, 15 Apr 2012 11:27:00 +0000]
fix warnings: suggest explicit braces to avoid ambiguous 'else' [-Wparentheses]
Wladimir J. van der Laan [Sun, 15 Apr 2012 11:03:28 +0000]
fix warnings: '&&' within '||' [-Wlogical-op-parentheses]
Wladimir J. van der Laan [Sun, 15 Apr 2012 10:59:20 +0000]
fix warnings: delete called on 'XX' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
Wladimir J. van der Laan [Sun, 15 Apr 2012 10:53:14 +0000]
fix warnings: unused variable 'XX' [-Wunused-variable]
Wladimir J. van der Laan [Sun, 15 Apr 2012 10:53:14 +0000]
fix warnings: unused variable 'XX' [-Wunused-variable]
Wladimir J. van der Laan [Sun, 15 Apr 2012 10:42:52 +0000]
fix warnings: enumeration values 'XX' not handled in switch [-Wswitch-enum]
Wladimir J. van der Laan [Sun, 15 Apr 2012 10:31:56 +0000]
fix warnings: 'XX' defined as a struct here but previously declared as a class [-Wmismatched-tags]
Wladimir J. van der Laan [Sun, 15 Apr 2012 10:22:30 +0000]
fix warnings: array subscript is of type 'char' [-Wchar-subscripts]
Wladimir J. van der Laan [Sun, 15 Apr 2012 10:22:30 +0000]
fix warnings: array subscript is of type 'char' [-Wchar-subscripts]
Wladimir J. van der Laan [Sun, 15 Apr 2012 09:42:40 +0000]
work around issue in boost::program_options that prevents from compiling in clang
Jeff Garzik [Sun, 15 Apr 2012 21:00:20 +0000]
Fix misc. minor sign-comparison warnings
Jeff Garzik [Sun, 15 Apr 2012 20:59:48 +0000]
CNode's nHeaderStart may be negative, so change its type
Jeff Garzik [Sun, 15 Apr 2012 20:59:09 +0000]
serialize.h: CAutoFile's read and write may take size_t nSize
Jeff Garzik [Sun, 15 Apr 2012 20:58:32 +0000]
Fix sign-compare warnings: netbase's Lookup* max-solutions may be unsigned
Jeff Garzik [Sun, 15 Apr 2012 20:52:09 +0000]
Fix loop index var types, fixing many minor sign comparison warnings
foo.size() typically returns an unsigned integral type; make loop variables
match those types' signedness.
Jeff Garzik [Sun, 15 Apr 2012 20:47:24 +0000]
The string class returns string::npos, when find() fails.
Noticed when sign-comparison warnings were enabled.
Jeff Garzik [Fri, 13 Apr 2012 22:20:44 +0000]
CTxMemPool: add helper methods, to reduce global mempool.mapTx accesses
Jeff Garzik [Fri, 13 Apr 2012 21:34:22 +0000]
CTxMemPool: encapsulate AcceptToMemoryPool
Jeff Garzik [Fri, 13 Apr 2012 20:28:07 +0000]
CTxMemPool: encapsulate AddToMemoryPoolUnchecked(), RemoveFromMemoryPool(),
and nPooledTx
Jeff Garzik [Fri, 13 Apr 2012 20:03:09 +0000]
New class CTxMemPool, encapsulating TX memory pool data members
Jeff Garzik [Sun, 15 Apr 2012 18:39:15 +0000]
Merge pull request #1104 from laanwj/2012_04_clang
Enable and fix most compilation warnings
Chris Moore [Thu, 12 Apr 2012 20:13:08 +0000]
CBitcoinSecret::SetString() now calls IsValid() to make sure it was passed something with the correct version.
Wladimir J. van der Laan [Sat, 14 Apr 2012 07:41:05 +0000]
Show a message box when runaway exception happens
This is more clear to users than when the program simply disappears (usually during initialization). It still logs the message to the console and debug log as well.
Luke Dashjr [Sun, 15 Apr 2012 17:23:43 +0000]
Merge commit 'e962c7f' into 0.5.0.x
Luke Dashjr [Sun, 15 Apr 2012 17:23:34 +0000]
Bugfix: nTotalBlocks wasn't in 0.5.0, so need to replace it with equivalent function call in backport
Luke Dashjr [Sun, 15 Apr 2012 17:08:21 +0000]
Bump version to 0.6.0.7
Skipping 0.6.0.1 through 0.6.0.6 since the internal version for 0.6.0[.0] was in fact 0.6.0.6
Luke Dashjr [Sun, 15 Apr 2012 01:00:27 +0000]
Bugfix: Check that QRcode_encodeString didn't return NULL (error)
Without this, any error will segfault Bitcoin-Qt
Jeff Garzik [Sun, 15 Apr 2012 16:25:29 +0000]
Merge pull request #1084 from dooglus/validate_secret
importprivkey doesn't check that it is given a private key
Wladimir J. van der Laan [Sun, 15 Apr 2012 16:22:26 +0000]
Merge pull request #1097 from laanwj/2012_04_runawayexception
Show a message box when runaway exception happens
Jeff Garzik [Sun, 15 Apr 2012 15:31:22 +0000]
Merge pull request #1100 from luke-jr/qrcode_errchk
Bugfix: Check that QRcode_encodeString didn't return NULL (error)
Wladimir J. van der Laan [Sun, 15 Apr 2012 11:27:00 +0000]
fix warnings: suggest explicit braces to avoid ambiguous 'else' [-Wparentheses]
Wladimir J. van der Laan [Sun, 15 Apr 2012 11:03:28 +0000]
fix warnings: '&&' within '||' [-Wlogical-op-parentheses]
Wladimir J. van der Laan [Sun, 15 Apr 2012 10:59:20 +0000]
fix warnings: delete called on 'XX' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
Wladimir J. van der Laan [Sun, 15 Apr 2012 10:53:14 +0000]
fix warnings: unused variable 'XX' [-Wunused-variable]
Wladimir J. van der Laan [Sun, 15 Apr 2012 10:42:52 +0000]
fix warnings: enumeration values 'XX' not handled in switch [-Wswitch-enum]
Wladimir J. van der Laan [Sun, 15 Apr 2012 10:31:56 +0000]
fix warnings: 'XX' defined as a struct here but previously declared as a class [-Wmismatched-tags]
Wladimir J. van der Laan [Sun, 15 Apr 2012 10:22:30 +0000]
fix warnings: array subscript is of type 'char' [-Wchar-subscripts]
Wladimir J. van der Laan [Sun, 15 Apr 2012 09:42:40 +0000]
work around issue in boost::program_options that prevents from compiling in clang
Wladimir J. van der Laan [Sun, 15 Apr 2012 10:24:03 +0000]
enable all warnings except invalid-offsetof, sign-compare, unused-parameter
Luke Dashjr [Sun, 15 Apr 2012 01:00:27 +0000]
Bugfix: Check that QRcode_encodeString didn't return NULL (error)
Without this, any error will segfault Bitcoin-Qt
Luke Dashjr [Sat, 14 Apr 2012 19:38:26 +0000]
Add symlink to scripts/qt/make_windows_icon.sh from old file name, just in case
Wladimir J. van der Laan [Sat, 14 Apr 2012 16:32:30 +0000]
Rename make_windows_icon.py to .sh as it is a shell script (fixes #1099)
Wladimir J. van der Laan [Sat, 14 Apr 2012 06:21:22 +0000]
Do not show green tick unless all known blocks are downloaded (fixes #921)
Wladimir J. van der Laan [Fri, 13 Apr 2012 07:16:46 +0000]
Add missing tooltip and key shortcut in settings dialog (#1088 without line break part)
Gavin Andresen [Thu, 5 Apr 2012 00:56:13 +0000]
Bug fix listtransactions from/count handling.
Luke Dashjr [Sat, 14 Apr 2012 19:27:12 +0000]
Display an error, rather than crashing, if encoding a QR Code failed.
(master workaround in
b1a99c3a1fb2613e9c7cecd565e8cc604b03eb6f +
7261945eb5f64423d47a5bff63ecd8b65d88b8ed)
Philip Kaufmann [Wed, 11 Apr 2012 12:21:15 +0000]
removed (no label) string if we have NO label
(partial of
9e0dba8c17eb6507083b4d7602541c25f1fd7f38)
Wladimir J. van der Laan [Sat, 14 Apr 2012 07:41:05 +0000]
Show a message box when runaway exception happens
This is more clear to users than when the program simply disappears (usually during initialization). It still logs the message to the console and debug log as well.
Wladimir J. van der Laan [Sat, 14 Apr 2012 16:32:30 +0000]
Rename make_windows_icon.py to .sh as it is a shell script (fixes #1099)
Jeff Garzik [Sat, 14 Apr 2012 15:50:43 +0000]
Merge pull request #1093 from jgarzik/tx-opt
Database micro-optimization for "tx" network message
Wladimir J. van der Laan [Sat, 14 Apr 2012 06:47:50 +0000]
Merge pull request #1089 from laanwj/2012_04_translationupdate
Update translations for bitcoin core
Wladimir J. van der Laan [Fri, 13 Apr 2012 06:45:26 +0000]
Update translations for bitcoin core
- Move scripts/qt to share/qt, to clean up toplevel directories
- Update english ts file which is used to source messages for Transifex
- In extract_strings_qt.py use a glob *.h *.cpp, this is safe now that the Wx UI files are removed
Wladimir J. van der Laan [Sat, 14 Apr 2012 06:27:23 +0000]
Merge pull request #1096 from laanwj/2012_04_tick
Do not show green tick unless all known blocks are downloaded (fixes #921)